Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade the minor k8s versions to latest #133

Merged
merged 7 commits into from
Oct 29, 2024
Merged

feat: upgrade the minor k8s versions to latest #133

merged 7 commits into from
Oct 29, 2024

Conversation

mpiscaer
Copy link
Contributor

No description provided.

@mpiscaer
Copy link
Contributor Author

recheck

2 similar comments
@mpiscaer
Copy link
Contributor Author

recheck

@mpiscaer
Copy link
Contributor Author

recheck

@okozachenko1203
Copy link
Member

/recheck

@okozachenko1203
Copy link
Member

@mpiscaer i can see zuul jobs are successful always and we have a few zuul jobs here. Almost all jobs are Github actions. So you'll need to jump into the Details of each job and just click rerun in Github GUI.

@mpiscaer
Copy link
Contributor Author

mpiscaer commented Sep 26, 2024 •
edited
Loading

@okozachenko1203 Yes, all Github action fails because of the helm chart of cert-manager timeout. So it is hard to troubleshoot without further debug information why the helm chart timeouts.

In my personal env I'm not able to reproduce it.

@okozachenko1203
Copy link
Member

@mpiscaer this is the fix 9ecce5d

@mpiscaer
Copy link
Contributor Author

@okozachenko1203 checks looks good thanks a lot for your effort.

@mnaser
Copy link
Member

mnaser commented Oct 24, 2024

@okozachenko1203 in #137 I tried to add Zuul support but it turns out 1.29+ has another weird kube-vip issue. Do you mind picking this up by actually copying over all the Zuul changes into here and bumping to latest minor (and dropping the old releases like I did in #137).

Then, we will work in #137 to try to fix the issue.

@yaguangtang yaguangtang force-pushed the upgradeMinorK8s branch 5 times, most recently from 3435fe3 to 62216a7 Compare October 28, 2024 13:10
mnaser
mnaser previously requested changes Oct 29, 2024
View reviewed changes
Copy link
Member

@mnaser mnaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should revert the kube_vip, those were only needed for 1.29+

Also, let's remove the aio from the matrix for GHA to avoid running it twice. We should also add the 1.26 and 1.27 jobs in Zuul as well.

@yaguangtang yaguangtang requested a review from mnaser October 29, 2024 04:36
mnaser
mnaser previously requested changes Oct 29, 2024
View reviewed changes
Copy link
Member

@mnaser mnaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change!

zuul.d/jobs-rockylinux9.yaml Show resolved Hide resolved
@mnaser mnaser added the gate label Oct 29, 2024
@atmosphere-ci Atmosphere CI
Copy link

atmosphere-ci bot commented Oct 29, 2024

Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry.

@mnaser mnaser merged commit 587b484 into vexxhost:main Oct 29, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaguangtang yaguangtang yaguangtang left review comments

@okozachenko1203 okozachenko1203 okozachenko1203 approved these changes

@mnaser mnaser mnaser left review comments

Assignees
No one assigned
Labels
gate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mpiscaer @okozachenko1203 @mnaser @yaguangtang