Merge pull request #23326 from vespa-engine/toregge/add-noexcept-spec…

…ifier Add noexcept specifier.
vespa-engine · Jul 3, 2022 · 6760568 · 6760568
2 parents a8d3000 + b8eb1f7
commit 6760568
Show file tree

Hide file tree

Showing 10 changed files with 14 additions and 14 deletions.
diff --git a/metrics/src/vespa/metrics/metric.cpp b/metrics/src/vespa/metrics/metric.cpp
@@ -52,7 +52,7 @@ Tag::Tag(vespalib::stringref k, vespalib::stringref v)
       _value(NameRepo::tagValueId(v))
 { }
 
-Tag::Tag(const Tag &) = default;
+Tag::Tag(const Tag &) noexcept = default;
 Tag & Tag::operator = (const Tag &) = default;
 Tag::~Tag() {}
 

diff --git a/metrics/src/vespa/metrics/metric.h b/metrics/src/vespa/metrics/metric.h
@@ -87,7 +87,7 @@ struct Tag
 
     Tag(vespalib::stringref k);
     Tag(vespalib::stringref k, vespalib::stringref v);
-    Tag(const Tag &);
+    Tag(const Tag &) noexcept;
     Tag & operator = (const Tag &);
     Tag(Tag &&) = default;
     Tag & operator = (Tag &&) = default;

diff --git a/searchlib/src/vespa/searchlib/diskindex/diskindex.cpp b/searchlib/src/vespa/searchlib/diskindex/diskindex.cpp
@@ -27,7 +27,7 @@ void swap(DiskIndex::LookupResult & a, DiskIndex::LookupResult & b)
     a.swap(b);
 }
 
-DiskIndex::LookupResult::LookupResult()
+DiskIndex::LookupResult::LookupResult() noexcept
     : indexId(0u),
       wordNum(0),
       counts(),

diff --git a/searchlib/src/vespa/searchlib/diskindex/diskindex.h b/searchlib/src/vespa/searchlib/diskindex/diskindex.h
@@ -31,7 +31,7 @@ class DiskIndex : public queryeval::Searchable {
         index::PostingListCounts         counts;
         uint64_t                         bitOffset;
         typedef std::unique_ptr<LookupResult> UP;
-        LookupResult();
+        LookupResult() noexcept;
         bool valid() const { return counts._numDocs > 0; }
         void swap(LookupResult & rhs) {
             std::swap(indexId , rhs.indexId);

diff --git a/searchlib/src/vespa/searchlib/features/termeditdistancefeature.cpp b/searchlib/src/vespa/searchlib/features/termeditdistancefeature.cpp
@@ -17,14 +17,14 @@ namespace search::features {
 //---------------------------------------------------------------------------------------------------------------------
 // TedCell
 //---------------------------------------------------------------------------------------------------------------------
-TedCell::TedCell() :
+TedCell::TedCell() noexcept :
     cost(util::FEATURE_MAX),
     numDel(0),
     numIns(0),
     numSub(0)
 {}
 
-TedCell::TedCell(feature_t argCost, uint32_t argNumDel, uint32_t argNumIns, uint32_t argNumSub) :
+TedCell::TedCell(feature_t argCost, uint32_t argNumDel, uint32_t argNumIns, uint32_t argNumSub) noexcept :
     cost(argCost),
     numDel(argNumDel),
     numIns(argNumIns),

diff --git a/searchlib/src/vespa/searchlib/features/termeditdistancefeature.h b/searchlib/src/vespa/searchlib/features/termeditdistancefeature.h
@@ -12,8 +12,8 @@ namespace search::features {
  */
 class TedCell {
 public:
-    TedCell();
-    TedCell(feature_t cost, uint32_t numDel, uint32_t numIns, uint32_t numSub);
+    TedCell() noexcept;
+    TedCell(feature_t cost, uint32_t numDel, uint32_t numIns, uint32_t numSub) noexcept;
 
     feature_t cost;   // The cost at this point.
     uint32_t  numDel; // The number of deletions to get here.

diff --git a/vespalib/src/tests/datastore/buffer_type/buffer_type_test.cpp b/vespalib/src/tests/datastore/buffer_type/buffer_type_test.cpp
@@ -27,7 +27,7 @@ struct Setup {
           _allocGrowFactor(0.5),
           _resizing(false)
     {}
-    Setup(const Setup& rhs);
+    Setup(const Setup& rhs) noexcept;
     Setup &minArrays(uint32_t value) { _minArrays = value; return *this; }
     Setup &used(size_t value) { _usedElems = value; return *this; }
     Setup &needed(size_t value) { _neededElems = value; return *this; }
@@ -36,7 +36,7 @@ struct Setup {
     Setup &resizing(bool value) { _resizing = value; return *this; }
 };
 
-Setup::Setup(const Setup& rhs)
+Setup::Setup(const Setup& rhs) noexcept
     : _minArrays(rhs._minArrays),
       _usedElems(rhs._usedElems.load(std::memory_order_relaxed)),
       _neededElems(rhs._neededElems),

diff --git a/vespalib/src/tests/util/generationhandler_stress/generation_handler_stress_test.cpp b/vespalib/src/tests/util/generationhandler_stress/generation_handler_stress_test.cpp
@@ -48,11 +48,11 @@ struct IndirectContext {
     static constexpr size_t values_size = 65536;
     uint64_t _values[values_size];
 
-    IndirectContext();
+    IndirectContext() noexcept;
     uint64_t* calc_value_ptr(uint64_t idx) { return &_values[(idx & (values_size - 1))]; }
 };
 
-IndirectContext::IndirectContext()
+IndirectContext::IndirectContext() noexcept
     : _value_ptr(nullptr),
       _pad(),
       _values()

diff --git a/vespalib/src/vespa/vespalib/util/adaptive_sequenced_executor.cpp b/vespalib/src/vespa/vespalib/util/adaptive_sequenced_executor.cpp
@@ -6,7 +6,7 @@ namespace vespalib {
 
 //-----------------------------------------------------------------------------
 
-AdaptiveSequencedExecutor::Strand::Strand()
+AdaptiveSequencedExecutor::Strand::Strand() noexcept
     : state(State::IDLE),
       queue()
 {

diff --git a/vespalib/src/vespa/vespalib/util/adaptive_sequenced_executor.h b/vespalib/src/vespa/vespalib/util/adaptive_sequenced_executor.h
@@ -80,7 +80,7 @@ class AdaptiveSequencedExecutor : public ISequencedTaskExecutor
         enum class State { IDLE, WAITING, ACTIVE };
         State state;
         ArrayQueue<TaggedTask> queue;
-        Strand();
+        Strand() noexcept;
         ~Strand();
     };