Merge pull request #32838 from vespa-engine/toregge/move-posting-list…

…-cache-size-in-proton-def Move posting list cache size in proton.def
vespa-engine · Nov 12, 2024 · 351a47b · 351a47b
2 parents 6a70c60 + a9d347e
commit 351a47b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/configdefinitions/src/vespa/proton.def b/configdefinitions/src/vespa/proton.def
@@ -543,9 +543,10 @@ index.cache.size long default=0 restart
 ##
 ## Is default turned off (maxbytes == 0).
 ## The cache will not be used if search.io == MMAP.
-## A postive number specifies the max size of the cache in bytes.
+## A positive number specifies the max size of the cache in bytes.
 ## A negative number specifies the max size of the cache as a percentage of total memory.
-index.postinglist.cache.maxbytes long default=0 restart
+index.cache.postinglist.maxbytes long default=0 restart
+index.cache.bitvector.maxbytes long default=0 restart
 
 ## Specifies which tensor implementation to use for all backend code.
 ##

diff --git a/searchcore/src/vespa/searchcore/proton/server/proton.cpp b/searchcore/src/vespa/searchcore/proton/server/proton.cpp
@@ -165,10 +165,10 @@ void ensureWritableDir(const std::string &dirName) {
 std::shared_ptr<IPostingListCache>
 make_posting_list_cache(const ProtonConfig& cfg)
 {
-    if (cfg.search.io == ProtonConfig::Search::Io::MMAP || cfg.index.postinglist.cache.maxbytes == 0) {
+    if (cfg.search.io == ProtonConfig::Search::Io::MMAP || cfg.index.cache.postinglist.maxbytes == 0) {
         return {};
     }
-    return std::make_shared<PostingListCache>(cfg.index.postinglist.cache.maxbytes);
+    return std::make_shared<PostingListCache>(cfg.index.cache.postinglist.maxbytes);
 }
 
 } // namespace <unnamed>