Sort list of available modules in verify-module error #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utaal
requested changes
Aug 16, 2023
source/rust_verify/src/verifier.rs
Outdated
| .collect::<Vec<_>>() | ||
| .join("\n"); | ||
| .collect::<Vec<_>>(); | ||
| lines.sort(); // Present the available modules in sorted order |
There was a problem hiding this comment.
I believe this would sort the two header lines too:
format!("could not find module {mod_name} specified by --verify-module"),
format!("available modules are:"),
and the footer line
format!("or use --verify-root, --verify-pervasive")
We should just sort the module lines.
There was a problem hiding this comment.
ha ha aaaawkward. Fixed.
utaal
approved these changes
Aug 16, 2023
|
Please squash when merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've had the experience that when I mistype an argument to --verify-module, I scan the list, don't see the expected module, and become irrationally furious. Sorting the list makes it easier to understand what's available.