Improvements to multiset, map pervasives #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(sorry map_lib diff is noisy -- I cleaned up a bunch of end-of-line whitespace and a broken end-of-file linefeed along the way. Here's to vargo fmt...) |
jonhnet
requested review from
tjhance and
utaal
and removed request for
tjhance
|
(removing tjhance as I forgot he was on vacation) |
utaal
approved these changes
Aug 16, 2023
|
as I said in the slack, the change to multiset is unsound unless |
Thank you for catching this (and sorry for missing it). It's reverted for now: 56edc01 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multiset: removed finite assumption (and axiom!), replaced with comment explaining that multiset can have infinite support, but not infinite multiplicity. Based::new comprehension on a function (consistent with other pervasive types), reworked other definitions to use it, and removed now-unnecessary axioms.
map: moved values from map.rs (should be just _t axioms) to map_lib (should be _v).