Make it more pleasant to write a proof-by-computation over a range of values #1338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in standard Rust
Chris-Hawblitzel
approved these changes
Nov 15, 2024
| @@ -114,6 +116,7 @@ pub broadcast group group_vstd_default { | |||
| string::group_string_axioms, | |||
| std_specs::range::group_range_axioms, | |||
| raw_ptr::group_raw_ptr_axioms, | |||
| compute::all_spec_implies, | |||
There was a problem hiding this comment.
The broadcast group range_all_spec is never used. Is it meant to be used here, instead of saying all_spec_implies directly here?
There was a problem hiding this comment.
Ah, I forgot I'd created the group. I could add it here so that we don't need to change vstd.rs if we add more lemmas in compute.rs. Or I can just delete the group from compute.rs.
There was a problem hiding this comment.
Ah, I forgot I'd created the group. I could add it here so that we don't need to change
vstd.rsif we add more lemmas incompute.rs. Or I can just delete the group fromcompute.rs.
Either way sounds fine to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.