Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added vertx-auth-webauthn4j module #197

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

FroMage
Copy link
Contributor

@FroMage FroMage commented Oct 10, 2024

This is the new WebAuthn4J module that will come in its own PR.

@vietj vietj merged commit 9c6866c into vert-x3:master Oct 10, 2024
3 checks passed
@vietj vietj added this to the 5.0.0 milestone Oct 10, 2024
@tsegismont
Copy link
Contributor

Thanks @FroMage

In case you missed it, there are other modules that must be updated: https://github.com/vert-x3/vertx-stack?tab=readme-ov-file#adding-a-new-module-to-the-stack

@FroMage
Copy link
Contributor Author

FroMage commented Oct 11, 2024

I did miss it indeed. Wow.

@FroMage FroMage deleted the webauthn4j branch October 11, 2024 09:29
@FroMage
Copy link
Contributor Author

FroMage commented Oct 11, 2024

Add it to the website in vertx-web-site:
Edit the docs summary page docs/metadata/.jsx, use Tech Preview label

That doesn't seem to be enough, I've added it in the vertx5 branch in 5.0.0-SNAPSHOT.jsx:

insert(docs, "vertx-auth-webauthn",
  {
    id: "vertx-auth-webauthn4j",
    name: "Webauthn Auth with WebAuthn4J",
    description: "FIDO2 WebAuthn (password-less) wrapper for WebAuthn4J.",
    category: "authentication-and-authorization",
    href: "/vertx-auth-webauthn4j/java/",
    repository: "https://github.com/eclipse-vertx/vertx-auth/tree/master/vertx-auth-webauthn4j",
    edit: "https://github.com/eclipse-vertx/vertx-auth/tree/master/vertx-auth-webauthn4j/src/main/asciidoc",
    label: "Technical Preview"
  }
 )

But I get a 404 when I build the site locally and go to http://localhost:3000/docs/vertx-auth-webauthn4j/java/ although I do see it listed in http://localhost:3000/docs/

Perhaps it's fine and it's because it's trying to look it up from github where it's not merged yet? Or perhaps I need to do something else for docs to be published?

@tsegismont
Copy link
Contributor

Have you run npm run update-docs ?

@michel-kraemer any other idea?

@michel-kraemer
Copy link
Member

@FroMage I've downloaded the stack docs zip built today (2024-11-10) from [1] but I cannot find a vertx-auth-webauthn4j folder inside of it. If you've already added the module to the stack, you may have to wait for the next nightly build.

Also, please submit your PR to my fork [2], which contains the latest version of the website. We will merge this fork into the main repository as soon as Vert.x 5 is released. The vertx5 branch is outdated and will be removed soon.

I hope this helps. Let me know if you have questions.

Cheers,
Michel

[1] https://s01.oss.sonatype.org/content/repositories/snapshots/io/vertx/vertx-stack-docs/5.0.0-SNAPSHOT/
[2] https://github.com/michel-kraemer/vertx-web-site.github.io

@tsegismont
Copy link
Contributor

Thank you @michel-kraemer !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants