ci(examples): test every package manager in Support Policy on basic
#9593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
anthonyshew
changed the title
anthonyshew
commented
Dec 13, 2024
| import { createGenerator } from "ts-json-schema-generator"; | ||
|
|
||
| const __dirname = new URL(".", import.meta.url).pathname; | ||
| const __dirname = fileURLToPath(new URL(".", import.meta.url)); |
There was a problem hiding this comment.
For posterity, this fixes a bug in generating types in @turbo/types on Windows.
There was a problem hiding this comment.
chris-olszewski
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recently, I updated external dependencies for the
basicexample and tested it with pnpm. Everything looked good - but our CI only testsbasicfor pnpm. I hadn't realized that I broke one of the other package managers.Instead of relying on making sure that we hand-test every package manager, let's test each one in CI.
This PR also removes a few of the examples from the test suite since we are not maintaining them. Because they are community maintained, we won't rely on them for our CI.
Testing Instructions
CI 🙏