feat(trace): resolve incorrect extension #9486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
chris-olszewski
approved these changes
Nov 21, 2024
| let type_package = format!("@types/{}", import); | ||
| let resolved_type_import = resolver | ||
| .resolve(file_path, type_package.as_str()) | ||
| if !import.starts_with(".") { |
There was a problem hiding this comment.
Is this a check against ./?
There was a problem hiding this comment.
Yeah. I don't think packages can start with .?
| } | ||
|
|
||
| // Also try without the extension just in case the wrong extension is used | ||
| let without_extension = Utf8Path::new(import).with_extension(""); |
There was a problem hiding this comment.
Just calling out that this will convert something like types.d.ts to types.d source, is that the desired behavior?
There was a problem hiding this comment.
So I originally had an explicit check for types.d.ts that stripped it all the way back to types but when I ran this on the other repo, that didn't fix any errors. I suspect oxc-resolver also treats types.d as the name, so this should work just fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Invalid extensions are unfortunately too common in imports. Therefore if we can't resolve with the extension, we strip it and try again.
Testing Instructions
Added a test where we try to import with the wrong extension