Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update upload-artifact and download-artifact actions to v4 #9447

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

Juneezee
Copy link
Contributor

Description

v3 of actions/upload-artifact and actions/download-artifact will be fully deprecated by 5 December 2024. Jobs that are scheduled to run during the brownout periods will also fail. See:

  1. https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
  2. https://github.blog/changelog/2024-11-05-notice-of-breaking-changes-for-github-actions/

Testing Instructions

Run the CI jobs

v3 of `actions/upload-artifact` and `actions/download-artifact` will be
fully deprecated by 5 December 2024. Jobs that are scheduled to run
during the brownout periods will also fail. See [1][2].

[1]: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
[2]: https://github.blog/changelog/2024-11-05-notice-of-breaking-changes-for-github-actions/

Signed-off-by: Eng Zer Jun <[email protected]>
@Juneezee Juneezee requested a review from a team as a code owner November 15, 2024 17:08
@turbo-orchestrator turbo-orchestrator bot added area: ci needs: triage New issues get this label. Remove it after triage labels Nov 15, 2024
Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 16, 2024 3:57am
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Nov 16, 2024 3:57am
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Nov 16, 2024 3:57am
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Nov 16, 2024 3:57am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Nov 16, 2024 3:57am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Nov 16, 2024 3:57am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Nov 16, 2024 3:57am
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Nov 16, 2024 3:57am
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Nov 16, 2024 3:57am

Copy link

vercel bot commented Nov 15, 2024

@Juneezee is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

name: profiles # This name will be the folder each file gets downloaded to
name: profiles-${{ matrix.os.name }} # This name will be the folder each file gets downloaded to
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v4 of actions/upload-artifact does not allow uploading to the same artifact name anymore and we need to give each artifact a unique name. See:

  1. https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md#multiple-uploads-to-the-same-named-artifact
  2. https://github.com/actions/upload-artifact?tab=readme-ov-file#not-uploading-to-the-same-artifact

This is the only workflow where we didn't give the artifact a unique name in matrix scenarios.

Comment on lines -117 to +119
name: profiles
path: packages/turbo-benchmark/profiles/
pattern: profiles-*
merge-multiple: true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ijjk
Copy link
Member

ijjk commented Nov 16, 2024

Allow CI Workflow Run

  • approve CI run for commit: 9c23bf1

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented Nov 16, 2024

Allow CI Workflow Run

  • approve CI run for commit: 9c23bf1

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link
Contributor

@anthonyshew anthonyshew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@anthonyshew anthonyshew merged commit 2881b1b into vercel:main Nov 16, 2024
35 checks passed
chris-olszewski added a commit that referenced this pull request Nov 19, 2024
### Description

#9447 bumped us to
`upload-artifact` to v4 which uses Node 20. Node 20 required a newer
glibc version than was available on our build that targeted AWS's
Lambda2's glibc version. See [this
job](https://github.com/vercel/turborepo/actions/runs/11897321603/job/33151832964#step:12:21)
for an example failure.

Requiring this glibc version isn't necessary for the musl builds since
it uses musl instead of glibc for libc.

I do not think this was intentional to have the musl binary building in
this container as we changed this back when we were cross compiling:
8ca67c3

Future work: This does not fix the `@turbo/repository` release.

### Testing Instructions

Ran test release and x86 msul build now passes:
[job](https://github.com/vercel/turborepo/actions/runs/11917567457/job/33214049836)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ci needs: triage New issues get this label. Remove it after triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants