fix(windows): fix env var glob casing #9429
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #9424 a user had
path
as their Windows env var instead ofPath
orPATH
. On Windows environment variables are case insensitive e.g.process.env.PATH
andprocess.env.Path
would both return the same. While fetching them might be the samestd::env::vars
returns the environment variable names cased as they were declared even thoughstd::env::var
is case insensitive on Windows.Take for example the following code:
On Windows it outputs:
On macOs it outputs:
Previously we had special casing for well known Windows env vars that were set differently between Command Prompt and Powershell, but would break if a user overwrote
Path
orPATH
topath
. This was brittle and a correct solution would require that we include all casing variations of all environment variables and users would also need to know how env vars were declared on their Windows system.This fix is to make our env var wildcard handling case in
Testing Instructions
Added unit test to make sure we