feat(mfe): add env var indicating mfe proxy #9395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
tknickman
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MFE development tasks may want to know if there's a corresponding proxy that is being run. Just checking if the proxy is running is error prone since they're both persistent tasks and there's no consistent way to prevent the check from running before the proxy server is listening on the port.
We avoid needing to perform this check by setting an environment variable for each development task if there's an associated proxy task in the configuration. It is then up to the underlying task to alter it's behavior depending on the presence of this variable.
Testing Instructions
In a project with a MFE, run a development task and verify that
TURBO_TASK_HAS_MFE_PROXYis set totrue