-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(examples): bug in design system example #9284
Open
zsh77
wants to merge
28
commits into
vercel:main
Choose a base branch
from
zsh77:fix/bug-in-design-system-example
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+56
−34
Open
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
24e8330
add preview-storybook task and script
zsh77 7719cbb
improvement on clean script
zsh77 4a750de
remove sourcemap of built files
zsh77 664a4a9
bug fix of README
zsh77 cc0e452
changed @acme/docs to @repo/docs
zsh77 bf0944e
Merge branch 'main' into improvement-on-design-system
zsh77 fc1d9df
Merge branch 'main' into improvement-on-design-system
zsh77 f02380a
Merge branch 'main' into improvement-on-design-system
zsh77 92da9a5
Merge branch 'main' into improvement-on-design-system
zsh77 e87a006
Merge branch 'main' into improvement-on-design-system
zsh77 ebb5128
Merge branch 'main' into improvement-on-design-system
zsh77 e033f9e
Merge branch 'main' into improvement-on-design-system
zsh77 5d61f2c
Merge branch 'main' into improvement-on-design-system
zsh77 4917e23
Merge branch 'main' into improvement-on-design-system
zsh77 6331bb5
Merge branch 'main' into improvement-on-design-system
zsh77 750e717
Merge branch 'main' into improvement-on-design-system
zsh77 c785ff0
Merge branch 'main' into improvement-on-design-system
zsh77 e982a25
update README.md to fix the built files of ui package in examples/des…
zsh77 e3aa870
Merge branch 'main' into fix/bug-in-design-system-example
zsh77 dacbcb9
Merge branch 'main' into fix/bug-in-design-system-example
zsh77 c297b08
Merge branch 'main' into fix/bug-in-design-system-example
zsh77 edcf600
Merge branch 'main' into fix/bug-in-design-system-example
zsh77 61c6590
Merge branch 'main' into fix/bug-in-design-system-example
zsh77 9633973
Merge branch 'main' into fix/bug-in-design-system-example
zsh77 722c8b6
Merge branch 'main' into fix/bug-in-design-system-example
zsh77 0fe2675
Merge branch 'main' into fix/bug-in-design-system-example
zsh77 3d0caf2
Merge branch 'main' into fix/bug-in-design-system-example
zsh77 c8079c6
Merge branch 'main' into fix/bug-in-design-system-example
zsh77 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,7 +8,8 @@ | |
"format": "prettier --write \"**/*.{ts,tsx,md}\"", | ||
"changeset": "changeset", | ||
"version-packages": "changeset version", | ||
"release": "turbo run build --filter=docs^... && changeset publish" | ||
"release": "turbo run build --filter=docs^... && changeset publish", | ||
"preview-storybook": "turbo preview-storybook" | ||
}, | ||
"devDependencies": { | ||
"@changesets/cli": "^2.27.1", | ||
|
@@ -17,4 +18,4 @@ | |
}, | ||
"packageManager": "[email protected]", | ||
"name": "design-system" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,6 +15,12 @@ | |
}, | ||
"clean": { | ||
"cache": false | ||
}, | ||
"preview-storybook": { | ||
"dependsOn": [ | ||
"^build" | ||
], | ||
"cache": false | ||
} | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe it's not related to this PR (as in, maybe it's already happening before this PR) but this 404's for me. does it work for you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dimitropoulos If you see fit, I could add this script in another merge request too. About the 404, you have to run the build script before the preview-storybook. Let me know if there was another thing going on.