Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tui): add Vim motions support for task list selection #9243

Merged
merged 1 commit into from
Nov 23, 2024
Merged

feat(tui): add Vim motions support for task list selection #9243

merged 1 commit into from
Nov 23, 2024

Conversation

AlvaroParker
Copy link
Contributor

@AlvaroParker AlvaroParker commented Oct 10, 2024 •
edited
Loading

Summary:

This PR introduces support for basic Vim-style key bindings within the tui component of TurboRepo, specifically for pane navigation. The goal is to improve navigation efficiency for users familiar with Vim-like key motions.

Key Changes:

  • Added support for j and k Vim keybinds for interactive mode:
    • Ctrl+j: Move down.
    • Ctrl+k: Move up.

Motivation:
Adding these motions provides a more intuitive interface for users familiar with Vim commands, enhancing navigation within the pane section of the TurboRepo UI.

Related discussion

@AlvaroParker AlvaroParker requested a review from a team as a code owner October 10, 2024 16:34
@turbo-orchestrator turbo-orchestrator bot added needs: triage New issues get this label. Remove it after triage owned-by: turborepo labels Oct 10, 2024
@vercel Vercel
Copy link

vercel bot commented Oct 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 23, 2024 3:56am
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Nov 23, 2024 3:56am
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Nov 23, 2024 3:56am
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Nov 23, 2024 3:56am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Nov 23, 2024 3:56am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Nov 23, 2024 3:56am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Nov 23, 2024 3:56am
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Nov 23, 2024 3:56am
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Nov 23, 2024 3:56am

@vercel Vercel
Copy link

vercel bot commented Oct 10, 2024

@AlvaroParker is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@dimitropoulos dimitropoulos self-requested a review October 15, 2024 20:46
@AlvaroParker
Copy link
Contributor Author

Don't really know why the workflows are failing. I updated my branch, waiting for approval : )

@dimitropoulos
Copy link
Contributor

hey just to keep you in the loop, I was reviewing this just now and we're gonna talk about it at our next team meeting and get back to you: there are some future plans for some of these keys (beyond just j and k) and we need to make sure we don't disrupt those plans.

@dimitropoulos
Copy link
Contributor

hey @AlvaroParker so I checked with the rest of the team and we'd like to just do j and k and nothing more - would you please update this PR to only add those keys?

@anthonyshew
Copy link
Contributor

Hey, @AlvaroParker! Just wanted to see if you're interested in finishing this one up. If not, we can remove the unwanted functionality on your behalf.

Thanks, excited for this!

@AlvaroParker
Copy link
Contributor Author

Hey @anthonyshew, sorry for not making the changes earlier—it’s been a busy couple of weeks. I’ve committed the changes to just use j and k. Let me know if I missed anything!

@ijjk
Copy link
Member

ijjk commented Nov 23, 2024 •
edited by anthonyshew
Loading

Allow CI Workflow Run

  • approve CI run for commit: f7b8a0b

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@anthonyshew anthonyshew changed the title Add Vim Motions Support to TurboRepo UI Input Handling feat(tui): add Vim motions support for task list selection Nov 23, 2024
anthonyshew
anthonyshew approved these changes Nov 23, 2024
View reviewed changes
Copy link
Contributor

@anthonyshew anthonyshew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries! Thanks for taking the time. Appreciate it!

@anthonyshew anthonyshew enabled auto-merge (squash) November 23, 2024 04:14
@anthonyshew anthonyshew merged commit 075d979 into vercel:main Nov 23, 2024
40 of 41 checks passed
@anthonyshew anthonyshew mentioned this pull request Nov 24, 2024
Merged
anthonyshew added a commit that referenced this pull request Nov 25, 2024
@anthonyshew
refactor(tui): cleanup where Vim binds were added. (#9508)
4808895 
### Description

In #9243, we added these keybinds for Vim. This refactors to put them in
an `|` OR and into the section that is for fallthroughs of interactive
mode.

### Testing Instructions

Try it out!
This was referenced Dec 4, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonyshew anthonyshew anthonyshew approved these changes

@tknickman tknickman Awaiting requested review from tknickman tknickman is a code owner automatically assigned from vercel/turbo-oss

@NicholasLYang NicholasLYang Awaiting requested review from NicholasLYang NicholasLYang is a code owner automatically assigned from vercel/turbo-oss

@dimitropoulos dimitropoulos Awaiting requested review from dimitropoulos

Assignees
No one assigned
Labels
needs: triage New issues get this label. Remove it after triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlvaroParker @dimitropoulos @anthonyshew @ijjk