Convert MDX errors into issues #8879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
mischnic
commented
Jul 30, 2024
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
mischnic
force-pushed
the
mischnic/pack-2589-mdx-error
branch
from
c4cea30 to
5f77174
Compare
|
An error occurred while trying to automatically change base from
mischnic/mdx-sourcetransform
to
main
July 30, 2024 14:49
mischnic
force-pushed
the
mischnic/pack-2589-mdx-error
branch
from
5f77174 to
07e46fa
Compare
mischnic
force-pushed
the
mischnic/pack-2589-mdx-error
branch
from
07e46fa to
15e813f
Compare
sokra
approved these changes
Jul 31, 2024
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 31, 2024
Trying vercel/turborepo#8031 again ~~Depends on vercel/turborepo#8766 <img width="979" alt="Bildschirmfoto 2024-07-30 um 15 35 48" src="https://github.com/user-attachments/assets/32d88ffc-c816-41fb-928b-79d27e89b56d"> --------- Co-authored-by: 강동윤 (Donny) <[email protected]>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
* vercel/turborepo#8879 <!-- Niklas Mischkulnig - Convert MDX errors into issues --> * vercel/turborepo#8873 <!-- Tobias Koppers - smarter logical combination that keeps truthy/falsy/nullish property --> * vercel/turborepo#8890 <!-- Tobias Koppers - Skip unreachable code when early return can be statically analysed -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
Trying vercel/turborepo#8031 again ~~Depends on vercel/turborepo#8766 <img width="979" alt="Bildschirmfoto 2024-07-30 um 15 35 48" src="https://github.com/user-attachments/assets/32d88ffc-c816-41fb-928b-79d27e89b56d"> --------- Co-authored-by: 강동윤 (Donny) <[email protected]>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 16, 2024
* vercel/turborepo#8879 <!-- Niklas Mischkulnig - Convert MDX errors into issues --> * vercel/turborepo#8873 <!-- Tobias Koppers - smarter logical combination that keeps truthy/falsy/nullish property --> * vercel/turborepo#8890 <!-- Tobias Koppers - Skip unreachable code when early return can be statically analysed -->
mischnic
added a commit
to vercel/next.js
that referenced
this pull request
Sep 24, 2024
This is of course still not great. Is there a way/will to have codeframes similar to vercel/turborepo#8879 when using Webpack? Before: ``` Error: page.mdx:Error: Message { place: Some(Point(7:1 (87))), reason: "Unexpected end of file in expression, expected a corresponding closing brace for `{`", rule_id: "unexpected-eof", source: "markdown-rs" } Import trace for requested module: ./app/blog/hello-world/page.mdx ⨯ ./app/blog/hello-world/page.mdx ``` After: ``` Error: page.mdx:Error: 7:1: Unexpected end of file in expression, expected a corresponding closing brace for `{` (markdown-rs:unexpected-eof) Import trace for requested module: ./app/blog/hello-world/page.mdx ⨯ ./app/blog/hello-world/page.mdx ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying #8031 again
Depends on #8766