Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to resolve symlinks on DirectoryEntry #8851

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Conversation

sokra
Copy link
Member

@sokra sokra commented Jul 26, 2024

Description

Just a little helper method to resolve symlinks when doing read_dir

Testing Instructions

Copy link

vercel bot commented Jul 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 0:20am
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 0:20am
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2024 0:20am
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2024 0:20am
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2024 0:20am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2024 0:20am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2024 0:20am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2024 0:20am
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2024 0:20am
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2024 0:20am

@sokra sokra marked this pull request as ready for review July 26, 2024 13:38
@sokra sokra requested a review from a team as a code owner July 26, 2024 13:38
@sokra sokra requested a review from wbinnssmith July 26, 2024 13:38
Copy link
Contributor

github-actions bot commented Jul 26, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

✅ This change can build next-swc

Copy link
Contributor

github-actions bot commented Jul 26, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

Copy link
Member Author

sokra commented Jul 29, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sokra and the rest of your teammates on Graphite Graphite

@sokra sokra merged commit 9061d95 into main Jul 29, 2024
56 of 57 checks passed
@sokra sokra deleted the sokra/resolve-symlink branch July 29, 2024 12:32
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

Just a little helper method to resolve symlinks when doing `read_dir`

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

Just a little helper method to resolve symlinks when doing `read_dir`

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
sokra added a commit to vercel/next.js that referenced this pull request Jul 31, 2024
### What?

When renaming a page from `page.js` to `page.tsx` it can temporarily
have both variants which end up writing the same files.

Also fixes symlinked page files

Depends on vercel/turborepo#8851

fixes PACK-2718
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
### Description

Just a little helper method to resolve symlinks when doing `read_dir`

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 14, 2024
### What?

When renaming a page from `page.js` to `page.tsx` it can temporarily
have both variants which end up writing the same files.

Also fixes symlinked page files

Depends on vercel/turborepo#8851

fixes PACK-2718
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 15, 2024
### What?

When renaming a page from `page.js` to `page.tsx` it can temporarily
have both variants which end up writing the same files.

Also fixes symlinked page files

Depends on vercel/turborepo#8851

fixes PACK-2718
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 16, 2024
### What?

When renaming a page from `page.js` to `page.tsx` it can temporarily
have both variants which end up writing the same files.

Also fixes symlinked page files

Depends on vercel/turborepo#8851

fixes PACK-2718
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants