Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move react, react-dom from devDependency to dependency in several examples #8192

Merged
merged 15 commits into from
Jun 17, 2024
+74 −39
Merged

chore: move react, react-dom from devDependency to dependency in several examples #8192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
e3ae1ff
chore: move react from devDependency to dependency in basic example
ghdtjgus76 May 22, 2024
871749b
chore: move react from devDependency to dependency in kitchen sink ex…
ghdtjgus76 May 22, 2024
39bcf84
chore: move react from devDependency to dependency in with berry example
ghdtjgus76 May 22, 2024
8d87d06
chore: move react from devDependency to dependency in with changesets…
ghdtjgus76 May 22, 2024
dea66f4
chore: move react from devDependency to dependency in with docker exa…
ghdtjgus76 May 22, 2024
40b67d1
chore: move react from devDependency to dependency in with gatsby exa…
ghdtjgus76 May 22, 2024
1aa4d18
chore: move react from devDependency to dependency in with npm example
ghdtjgus76 May 22, 2024
e948db0
chore: move react from devDependency to dependency in with rollup exa…
ghdtjgus76 May 22, 2024
6bd3205
chore: remove duplicated react dependency from devDependency
ghdtjgus76 May 22, 2024
59d1ea8
chore: move react from devDependency to dependency in with yarn example
ghdtjgus76 May 22, 2024
ee09b78
fix: fix merge conflict
ghdtjgus76 Jun 16, 2024
17650e3
Merge branch 'main' into chore/move-dependency
ghdtjgus76 Jun 16, 2024
afc9c77
Merge branch 'main' into chore/move-dependency
anthonyshew Jun 16, 2024
0fe28cb
Merge branch 'main' into chore/move-dependency
ghdtjgus76 Jun 17, 2024
17721f3
fix: fix rollup dependency
ghdtjgus76 Jun 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion examples/basic/packages/ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@
"@types/react": "^18.2.61",
"@types/react-dom": "^18.2.19",
"eslint": "^8.57.0",
"react": "^18.2.0",
"typescript": "^5.3.3"
},
"dependencies": {
"react": "^18.2.0"
}
}
7 changes: 4 additions & 3 deletions examples/basic/pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 5 additions & 3 deletions examples/kitchen-sink/packages/ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,11 @@
"@types/react": "^18.2.62",
"@types/react-dom": "^18.2.19",
"jest": "^29.7.0",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"tsup": "^8.0.2",
"typescript": "^5.3.3"
},
"dependencies": {
"react": "^18.2.0",
"react-dom": "^18.2.0"
}
}
}
16 changes: 10 additions & 6 deletions examples/kitchen-sink/pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion examples/with-berry/packages/ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@
"@types/react": "^18.2.61",
"@types/react-dom": "^18.2.19",
"eslint": "^8.57.0",
"react": "^18.2.0",
"typescript": "^5.3.3"
},
"dependencies": {
"react": "^18.2.0"
}
}
4 changes: 3 additions & 1 deletion examples/with-changesets/packages/acme-core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,12 @@
"@types/react-dom": "^18.2.19",
"eslint": "^8.57.0",
"@acme/eslint-config": "workspace:*",
"react": "^18.2.0",
"tsup": "^8.0.2",
"typescript": "^5.3.3"
},
"dependencies": {
"react": "^18.2.0"
},
"publishConfig": {
"access": "public"
}
Expand Down
4 changes: 3 additions & 1 deletion examples/with-changesets/packages/acme-utils/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,12 @@
"@types/react-dom": "^18.2.19",
"eslint": "^8.57.0",
"@acme/eslint-config": "workspace:*",
"react": "^18.2.0",
"tsup": "^8.0.2",
"typescript": "^5.3.3"
},
"dependencies": {
"react": "^18.2.0"
},
"publishConfig": {
"access": "public"
}
Expand Down
15 changes: 9 additions & 6 deletions examples/with-changesets/pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion examples/with-docker/packages/ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,10 @@
"@types/react-dom": "^18.2.19",
"eslint": "^8.57.0",
"@repo/eslint-config": "*",
"react": "^18.2.0",
"@repo/typescript-config": "*",
"typescript": "^5.3.3"
},
"dependencies": {
"react": "^18.2.0"
}
}
4 changes: 3 additions & 1 deletion examples/with-gatsby/packages/ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@
"@types/react": "^18.2.61",
"@types/react-dom": "^18.2.19",
"eslint": "^8.57.0",
"react": "^18.2.0",
"typescript": "^5.3.3"
},
"dependencies": {
"react": "^18.2.0"
}
}
8 changes: 5 additions & 3 deletions examples/with-gatsby/pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion examples/with-npm/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion examples/with-npm/packages/ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@
"@types/react": "^18.2.61",
"@types/react-dom": "^18.2.19",
"eslint": "^8.57.0",
"react": "^18.2.0",
"typescript": "^5.3.3"
},
"dependencies": {
"react": "^18.2.0"
}
}
4 changes: 3 additions & 1 deletion examples/with-rollup/packages/ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,10 @@
"@types/react": "^18.2.61",
"@types/react-dom": "^18.2.19",
"eslint": "^8.57.0",
"react": "^18.2.0",
"rollup": "^4.12.0",
"typescript": "^5.3.3"
},
"dependencies": {
"react": "^18.2.0"
}
}
8 changes: 5 additions & 3 deletions examples/with-rollup/pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions examples/with-tailwind/packages/ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@
"@types/react": "^18.2.61",
"autoprefixer": "^10.4.18",
"postcss": "^8.4.35",
"react": "^18.2.0",
"tailwindcss": "^3.4.1",
"typescript": "^5.3.3"
}
}
}
8 changes: 5 additions & 3 deletions examples/with-tailwind/pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion examples/with-yarn/packages/ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@
"@types/react": "^18.2.61",
"@types/react-dom": "^18.2.19",
"eslint": "^8.57.0",
"react": "^18.2.0",
"typescript": "^5.3.3"
},
"dependencies": {
"react": "^18.2.0"
}
}
Loading