fix(turbopack): Fix edge cases of tree shaking

[kdy1]

Description

Closes PACK-2966

Testing Instructions

I'll add some tests

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
examples-nonmonorepo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 28, 2024 2:18am
rust-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 28, 2024 2:18am
turbo-turbo-tracing-next-plugin	❌ Failed (Inspect)			May 28, 2024 2:18am

8 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
examples-basic-web	⬜️ Ignored (Inspect)	Visit Preview		May 28, 2024 2:18am
examples-designsystem-docs	⬜️ Ignored (Inspect)	Visit Preview		May 28, 2024 2:18am
examples-gatsby-web	⬜️ Ignored (Inspect)	Visit Preview		May 28, 2024 2:18am
examples-kitchensink-blog	⬜️ Ignored (Inspect)	Visit Preview		May 28, 2024 2:18am
examples-native-web	⬜️ Ignored (Inspect)	Visit Preview		May 28, 2024 2:18am
examples-svelte-web	⬜️ Ignored (Inspect)	Visit Preview		May 28, 2024 2:18am
examples-tailwind-web	⬜️ Ignored (Inspect)	Visit Preview		May 28, 2024 2:18am
examples-vite-web	⬜️ Ignored (Inspect)	Visit Preview		May 28, 2024 2:18am

[github-actions]

🟢 Turbopack Benchmark CI successful 🟢

Thanks

[github-actions]

✅ This change can build next-swc

[github-actions]

⚠️ CI failed ⚠️

The following steps have failed in CI:

• Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

[kdy1]

The test case with added issues is a wrong test case, but I'm not sure what should I do.

package-star/index.js

export { notCompiled } from "./not-compiled.js";
export { notExisting } from "./not-existing.js";
export { notExecuted } from "./not-executed.js";
export * from "./not-executed.js";
export * from "./a.js";
export * from "./b.js";
export const local = "local";

We import a and b from package-star in test case, but we cannot deduce that we can ignore

export { notCompiled } from "./not-compiled.js";
export { notExisting } from "./not-existing.js";
export { notExecuted } from "./not-executed.js";

because we have several export * from 'package-star's. We need to pass down a and b to export * from 'package-star's but I expect it to be a large work by itself.

So, I want to get this PR merged without it and work on it as a separate PR.

This is for two purposes:

• I can start working on scope hoisting in parallel
• I want to make WIP small.

Problematic case

package-reexport-tla-side-effect/index.js:

export * from "package-star";
export * from "./side-effect.js";
import "./side-effect2.js";
export const outer = "outer";

import { effect } from "./check-side-effect.js";

effect("index.js");

We import a and b from package-reexport-tla-side-effect, we can know that we don't need all exports, but we don't have a good way to pass those requirements to package-star.

[sokra]

I haven't fully reviewed it, but if it passes all tests it sounds fine to merge.
We can continue to iterate on it in future PRs