Skip to content

Commit

Permalink
fix(examples): remove --filter from with-docker example. (#9513)
Browse files Browse the repository at this point in the history
### Description

`--filter` isn't needed after running `prune` since the target from the
prune is the only application in the pruned workspace. This was
confusing someone in
#9496.
  • Loading branch information
anthonyshew authored Nov 25, 2024
1 parent b00eea2 commit e3fcdee
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions docs/repo-docs/guides/tools/docker.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ RUN yarn install
# Build the project
COPY --from=builder /app/out/full/ .
RUN yarn turbo run build --filter=web...
RUN yarn turbo run build
FROM base AS runner
WORKDIR /app
Expand Down Expand Up @@ -201,7 +201,7 @@ ENV TURBO_TEAM=$TURBO_TEAM
ARG TURBO_TOKEN
ENV TURBO_TOKEN=$TURBO_TOKEN
RUN yarn turbo run build --filter=web...
RUN yarn turbo run build
```

`turbo` will now be able to hit your Remote Cache. To see a Turborepo cache hit for a non-cached Docker build image, run a command like this one from your project root:
Expand Down
2 changes: 1 addition & 1 deletion examples/with-docker/apps/api/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ COPY --from=builder /app/out/full/ .
# ARG TURBO_TOKEN
# ENV TURBO_TOKEN=$TURBO_TOKEN

RUN yarn turbo build --filter=api...
RUN yarn turbo build

FROM base AS runner
WORKDIR /app
Expand Down
2 changes: 1 addition & 1 deletion examples/with-docker/apps/web/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ COPY --from=builder /app/out/full/ .
# ARG TURBO_TOKEN
# ENV TURBO_TOKEN=$TURBO_TOKEN

RUN yarn turbo build --filter=web...
RUN yarn turbo build

FROM base AS runner
WORKDIR /app
Expand Down

0 comments on commit e3fcdee

Please sign in to comment.