Skip to content

Commit

Permalink
fix(tui): make sure to open stdin for all tasks (#9354)
Browse files Browse the repository at this point in the history
### Description

In #9306 I somehow dropped the
`cmd.open_stdin()` call so we never started tasks hooked up to stdin.

I verified I copied the closing/forwarding stdin logic in my refactor
[as seen
here](https://github.com/vercel/turborepo/blob/main/crates/turborepo-lib/src/task_graph/visitor/exec.rs#L376),
we were just never opening it in the first place.

### Testing Instructions

`turbo_dev dev` should now let you interact with `persistent` tasks
  • Loading branch information
chris-olszewski authored Oct 30, 2024
1 parent f2a191b commit 7f12bad
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions crates/turborepo-lib/src/task_graph/visitor/command.rs
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,10 @@ impl<'a> CommandFactory<'a> {
cmd.env_clear();
cmd.envs(environment.iter());

// We always open stdin and the visitor will close it depending on task
// configuration
cmd.open_stdin();

Ok(Some(cmd))
}
}

0 comments on commit 7f12bad

Please sign in to comment.