-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: update contributing and troubleshooting docs (#9231)
### Description Ran into some weird integration test failures due to wrong `npm` version. Put a note in docs and in the setup script. While I was there, added some stuff to `CONTRIBUTING.md` and removed old references to Go. ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> --------- Co-authored-by: Dimitri Mitropoulos <[email protected]>
- Loading branch information
1 parent
0ee4d42
commit 4402e7d
Showing
3 changed files
with
41 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,6 +5,8 @@ set -eo pipefail | |
FIXTURE_NAME="${1-basic_monorepo}" | ||
|
||
# Default to version of npm installed with Node 18.20.2 | ||
# If CI is failing, check that this version is the same as | ||
# the CI runner's version of npm | ||
PACKAGE_MANAGER="[email protected]" | ||
if [[ $2 != "" ]]; then | ||
PACKAGE_MANAGER="$2" | ||
|