Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve form submissions, update packages. #1209

Merged
merged 16 commits into from
Oct 11, 2023
Merged

Improve form submissions, update packages. #1209

merged 16 commits into from
Oct 11, 2023

Conversation

leerob
Copy link
Member

@leerob leerob commented Oct 1, 2023 •
edited
Loading

  • Switch to <form> and useFormState for progressively enhanced forms
  • Fix some accessibility issues
    • Improved color contrast
    • Added live region for announcing errors
    • Switch from button disabled to aria-disabled
  • Update all dependencies
  • Ditch router.refresh() to revalidateTag and tag the cart fetch
  • Add a key to input to that changing search values correct re-renders and clears value
  • Updated Prettier config to work with latest ESM versions (+ Tailwind config)
  • Prevent duplicate clicks on buttons causing multiple form submissions

@vercel
Copy link

vercel bot commented Oct 1, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
commerce-shopify ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2023 2:44am

orca-security-us[bot]
orca-security-us bot reviewed Oct 1, 2023
View reviewed changes
Copy link

@orca-security-us orca-security-us bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

@leerob leerob marked this pull request as ready for review October 1, 2023 17:15
@manovotny manovotny marked this pull request as draft October 2, 2023 16:05
@srizvi srizvi mentioned this pull request Oct 4, 2023
Open
@leerob leerob marked this pull request as ready for review October 5, 2023 00:33
manovotny
manovotny reviewed Oct 8, 2023
View reviewed changes
pnpm-lock.yaml Outdated Show resolved Hide resolved
@manovotny
Copy link
Collaborator

manovotny commented Oct 8, 2023 •
edited
Loading

Personally, I don't like the .bind calls. I don't see the value in using them over hidden inputs (at least in this scenario) and I think it adds unneeded complexity and potential footguns (especially for beginners). I'll stand down if this is the preferred direction, but I wanted to mention it.

@manovotny manovotny merged commit 1f47796 into main Oct 11, 2023
5 checks passed
@manovotny manovotny deleted the updates branch October 11, 2023 02:45
bc-alexsaiannyi pushed a commit to bigcommerce/nextjs-commerce that referenced this pull request Dec 7, 2023
@leerob @bc-alexsaiannyi
Improves form submissions and updates dependencies (vercel#1209)
f4dc5eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orca-security-us orca-security-us[bot] orca-security-us[bot] left review comments

@manovotny manovotny manovotny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leerob @manovotny