Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Nonce size limits #4

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

chendave
Copy link
Member

This change wants to sync with veraison/ear#35.

@chendave
Copy link
Member Author

cc @setrofim

This change wants to sync with veraison/ear#35.

Signed-off-by: Dave Chen <[email protected]>
@chendave
Copy link
Member Author

@yogeshbdeshpande, I guess @setrofim is on vacation? Do you have privilege to merge this?

Copy link
Contributor

@yogeshbdeshpande yogeshbdeshpande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yogeshbdeshpande
Copy link
Contributor

@chendave Thank you for making the change!

@yogeshbdeshpande yogeshbdeshpande merged commit fc49755 into veraison:main Oct 19, 2023
4 checks passed
@thomas-fossati
Copy link
Contributor

Hi, @chendave, thanks!

Hint: next time you need a review, please select your reviewers using the "Reviewers" tab. This went completely unnoticed.

@chendave
Copy link
Member Author

thanks @yogeshbdeshpande and @thomas-fossati :)

some context for this change, which is needed here: confidential-containers/attestation-service#147

@chendave
Copy link
Member Author

Hint: next time you need a review, please select your reviewers using the "Reviewers" tab.

I don't have the privilege to do that. 😄

@chendave chendave deleted the noncesize branch October 19, 2023 08:51
@yogeshbdeshpande
Copy link
Contributor

Let me do the necessary admin

@thomas-fossati
Copy link
Contributor

Let me do the necessary admin

already done

@chendave
Copy link
Member Author

already done

cool, works for me now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants