Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track Cargo.lock in git #15

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

jpbrucker
Copy link
Contributor

Enable creating a buildroot package for keybroker-app.

To build packages deterministically, buildroot needs the Cargo.lock file to precisely describe all dependencies. In general the cargo doc recommends checking Cargo.lock into the repo:

https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html

Cargo.lock is automatically generated on build, and changes alongside Cargo.toml.

@jpbrucker
Copy link
Contributor Author

Note that this will soft conflict with other PRs that update Cargo.toml (#16). If they are merged first I'll rebase this patch.

@Arnaud-de-Grandmaison-ARM
Copy link
Collaborator

Arnaud-de-Grandmaison-ARM commented Oct 4, 2024

While I totally agree with @jpbrucker, I have #17 that will be pushed as soon as #16 is merged. It affects all the Cargo.toml in the repository by moving the dependency management to the top Cargo.toml and making the individual projects inherit from the central dependencies and use the piece they need. I would thus suggest to merge this PR once #16 and #17 have been merged. Our Cargo.toml / Cargo.lock story will then be in a good shape !

To build packages deterministically, buildroot needs the Cargo.lock file
to precisely describe all dependencies. In general the cargo doc
recommends checking Cargo.lock into the repo:

https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html

Cargo.lock is automatically generated on build, and changes alongside
Cargo.toml.

Signed-off-by: Jean-Philippe Brucker <[email protected]>
@Arnaud-de-Grandmaison-ARM Arnaud-de-Grandmaison-ARM merged commit 50d0e17 into veraison:main Oct 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants