Merge pull request #381 from veraPDF/fixer_config

Remove fixId from MetadataFixerConfig
veraPDF · Sep 28, 2023 · 9b923cc · 9b923cc
2 parents 5b6c3f0 + 8de3e62
commit 9b923cc
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/gui/src/main/java/org/verapdf/cli/commands/VeraCliArgParser.java b/gui/src/main/java/org/verapdf/cli/commands/VeraCliArgParser.java
@@ -582,7 +582,7 @@ public FeatureExtractorConfig featureExtractorConfig() {
 	}
 
 	public MetadataFixerConfig fixerConfig() {
-		return FixerFactory.configFromValues(this.prefix, true);
+		return FixerFactory.configFromValues(this.prefix);
 	}
 
 	public VeraAppConfig appConfig(final VeraAppConfig base) {

diff --git a/gui/src/main/java/org/verapdf/gui/PDFValidationApplication.java b/gui/src/main/java/org/verapdf/gui/PDFValidationApplication.java
@@ -151,7 +151,7 @@ public void actionPerformed(ActionEvent e) {
 					}
 
 					MetadataFixerConfig fixConf = FixerFactory
-							.configFromValues(PDFValidationApplication.this.settingsPanel.getFixMetadataPrefix(), true);
+							.configFromValues(PDFValidationApplication.this.settingsPanel.getFixMetadataPrefix());
 					try {
 						configManager.updateFixerConfig(fixConf);
 					} catch (JAXBException | IOException excep) {

diff --git a/gui/src/test/java/org/verapdf/apps/ConfigManagerTests.java b/gui/src/test/java/org/verapdf/apps/ConfigManagerTests.java
@@ -149,7 +149,7 @@ public void testUpdateFixerConfig() throws JAXBException, IOException {
 		ConfigManager newManager = Applications.createTmpConfigManager();
 		assertNotSame(defaultConfig, newManager.getFixerConfig());
 		assertEquals(defaultConfig, newManager.getFixerConfig());
-		MetadataFixerConfig newConfig = FixerFactory.configFromValues("NOT_DEFAULT", !defaultConfig.isFixId());
+		MetadataFixerConfig newConfig = FixerFactory.configFromValues("NOT_DEFAULT");
 		newManager.updateFixerConfig(newConfig);
 		assertNotEquals(defaultConfig, newManager.getFixerConfig());
 	}