fix: Use relative paths in .po file source comments #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses the issue where file paths in .po file comments were absolute, reflecting the local machine's directory structure. Fixes vendure-ecommerce#63
|
@michaelbromley do not release after you merge this PR because I'll create a follow up PR for adding the flag to disable comments in the po files. |
The `--po-source-locations` option controls whether to include file location comments in `.po` files. Defaults to `true`. `--po-source-locations=false` or `--no-po-source-locations`: Excludes location comments. Closes vendure-ecommerce#63
|
@michaelbromley I pushed the extra commit for adding the CLI option to toggle the source locations in this branch, so after merging you can proceed with releasing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the issue where file paths in .po file comments were absolute, reflecting the local machine's directory structure.
Fixes #63
Also added more integration tests and updated them to use a local build instead of compiling with tsx to have the behavior close to what is published, and to prevent situations like #58 and #62.