Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Add debug tooling #51

Merged
merged 1 commit into from
Oct 12, 2024
Merged

Enhancement: Add debug tooling #51

merged 1 commit into from
Oct 12, 2024

Conversation

BenjamenMeyer
Copy link
Member

@BenjamenMeyer BenjamenMeyer commented Oct 12, 2024 •
edited
Loading

Thank you for submitting a pull request and becoming a contributor to Vega Strike's Build System Docker Images.

Please answer the following:

Code Changes:

  • This is a documentation change only
  • CI Change

Issues:

Purpose:

  • Dockerfile that can be used to load the VS code for testing
  • vs-images.sh that can be used to orchestrate docker
  • README.md to document how to use it all
  • Drop Rocky Linux 8.10 Support for the time being as there is a build issue on that platform without a clear resolution. Will restore if someone from the community can help out with fixing the issues.

@BenjamenMeyer
Enhancement: Add debug tooling
2109eb3 
- Dockerfile that can be used to load the VS code for testing
- vs-images.sh that can be used to orchestrate docker
- README.md to document how to use it all
@BenjamenMeyer BenjamenMeyer added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 12, 2024
@BenjamenMeyer BenjamenMeyer self-assigned this Oct 12, 2024
royfalk
royfalk approved these changes Oct 12, 2024
View reviewed changes
Copy link

@royfalk royfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks very useful. LGTM.

@BenjamenMeyer BenjamenMeyer merged commit 97bb3bf into vegastrike:master Oct 12, 2024
49 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@royfalk royfalk royfalk approved these changes

@Loki1950 Loki1950 Awaiting requested review from Loki1950

Assignees

@BenjamenMeyer BenjamenMeyer

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BenjamenMeyer @royfalk