Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move player info and upgrade view to python #904

Merged
merged 17 commits into from
Nov 28, 2024
Merged

Conversation

royfalk
Copy link
Contributor

@royfalk royfalk commented Nov 11, 2024

Code Changes:

Issues:

  • None

Copy link
Member

@BenjamenMeyer BenjamenMeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should make sure that the Engine API version has changed since 0.9.x.

0.9.x is version 2 so with this change 0.10.x should be version 3.

@royfalk royfalk mentioned this pull request Nov 14, 2024
2 tasks
Copy link
Contributor

@evertvorster evertvorster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does fix the issue with the SPEC capacitor description, and with this branch merged, I cannot find anything wrong with the game. Should be good to go, from a playability perspective.

@royfalk royfalk merged commit aaeb622 into master Nov 28, 2024
43 checks passed
@royfalk royfalk deleted the task_ship_info_3 branch November 28, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants