0.9.x Build Troubleshooting Early December 2023 SGT #821
Conversation
| set -e | ||
|
|
||
| PACKAGE_SPEC="$1" | ||
| LEAVE_LINKED="$2" |
There was a problem hiding this comment.
Would be good to have some comments describing how to use this script and the meaning of the parameters.
There was a problem hiding this comment.
@BenjamenMeyer Agreed. It would be good. :-)
There was a problem hiding this comment.
... To finish the thought: Can we delay adding the comments until a future PR? Or do they need to be added right now, in your opinion?
There was a problem hiding this comment.
Okay, sounds good. I'll file a new issue for that documentation work
|
@stephengtuggy please rerun the Mac-CI builds so we can see what's broken. |
@BenjamenMeyer I'd be happy to. Unfortunately, the Rerun button appears to be disabled. Maybe because the CI builds for this PR last ran so many months ago? I plan to port some of the needed changes that were just merged into 0.8.x, into this PR branch. That should trigger a fresh run of the CI builds, and hopefully fix some or all of the remaining errors as well. |
|
Perhaps just do a minor change (whitespace?) and push. Unfortunately it runs everything. |
|
Closing in favor of #851 , which includes pretty much all of the important changes from this PR. |
…ncorporate changes from PR vegastrike#821 ; fix macOS detection ("Darwin")
Thank you for submitting a pull request and becoming a contributor to the Vega Strike Core Engine.
Please answer the following:
Code Changes:
Issues Fixed By This PR:
Fixes #812 for 0.9.x and following
Purpose:
Issues Remaining, observed during testing:
#823
#793