Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.8.x Build Troubleshooting Late November Early December 2023 SGT #820

Conversation

stephengtuggy
Copy link
Contributor

@stephengtuggy stephengtuggy commented Dec 4, 2023

Thank you for submitting a pull request and becoming a contributor to the Vega Strike Core Engine.

Please answer the following:

Code Changes:

Issues:
Closes #782
Closes #783
Fixes #812 for 0.8.x

Purpose:

  • What is this pull request trying to do? Get Windows, Linux, and macOS CI builds all succeeding consistently
  • What release is this for? 0.8.x
  • Is there a project or milestone we should apply this to? 0.8.x

Copy link
Member

@BenjamenMeyer BenjamenMeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@stephengtuggy stephengtuggy merged commit ff497c6 into vegastrike:0.8.x Dec 9, 2023
30 checks passed
@stephengtuggy stephengtuggy deleted the 0.8.x_build_troubleshooting_2023-11_sgt branch December 9, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants