Merge pull request #888 from BenjamenMeyer/release-actions_0.9.x

Actions: migrate release artifact GH action
vegastrike · Oct 6, 2024 · 1245aa3 · 1245aa3
2 parents cdb2325 + c069832
commit 1245aa3
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 31 deletions.
diff --git a/.github/workflows/Windows-Release.yml b/.github/workflows/Windows-Release.yml
@@ -122,16 +122,9 @@ jobs:
           name: test_results_xml
           path: ${{github.workspace}}/build/test-results/**/*.xml
 
-      #- name: Upload artifacts
-      #  uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 #v4.3.3
-      #  with:
-      #    path: "${{ github.workspace }}/build/**/*.zip"
-
-      # TODO: Find/write a tool to upload release for Windows
-      # - name: Upload artifacts
-      #  uses: skx/github-action-publish-binaries@44887b225ceca96efd8a912d39c09ad70312af31 # master
-      #  env:
-      #    GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-      #    ARTIFACT_EXT: ${{ matrix.ARTIFACT_EXT }}
-      #  with:
-      #    path: "${{ github.workspace }}/**/*.zip"
+      - name: Upload the artifacts
+        uses: softprops/action-gh-release@c062e08bd532815e2082a85e87e3ef29c3e6d191 # v2.0.8
+        if: startsWith(github.ref, 'refs/tags/')
+        with:
+          token: ${{ secrets.GITHUB_TOKEN }}
+          files: "packages/*.${{ matrix.ARTIFACT_EXT }}"
diff --git a/.github/workflows/gh-actions-release.yml b/.github/workflows/gh-actions-release.yml
@@ -129,9 +129,8 @@ jobs:
         run: script/cibuild $FLAGS
 
       - name: Upload the artifacts
-        uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 #v4.3.3
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          ARTIFACT_EXT: ${{ matrix.ARTIFACT_EXT }}
+        uses: softprops/action-gh-release@c062e08bd532815e2082a85e87e3ef29c3e6d191 # v2.0.8
+        if: startsWith(github.ref, 'refs/tags/')
         with:
-          args: "packages/*.${{ matrix.ARTIFACT_EXT }}"
+          token: ${{ secrets.GITHUB_TOKEN }}
+          files: "packages/*.${{ matrix.ARTIFACT_EXT }}"
diff --git a/.github/workflows/macos-release.yml b/.github/workflows/macos-release.yml
@@ -106,16 +106,9 @@ jobs:
           name: test_results_xml
           path: ${{github.workspace}}/build/test-results/**/*.xml
 
-      #- name: Upload the artifacts
-      #  uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 #v4.3.3
-      #  with:
-      #    args: "packages/*.${{ matrix.ARTIFACT_EXT }}"
-
-      # TODO: Find/write a tool to upload release for Mac OS
-      # - name: Upload the artifacts
-      #  uses: skx/github-action-publish-binaries@44887b225ceca96efd8a912d39c09ad70312af31 # master
-      #  env:
-      #    GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-      #    ARTIFACT_EXT: ${{ matrix.ARTIFACT_EXT }}
-      #  with:
-      #    args: "packages/*.${{ matrix.ARTIFACT_EXT }}"
+      - name: Upload the artifacts
+        uses: softprops/action-gh-release@c062e08bd532815e2082a85e87e3ef29c3e6d191 # v2.0.8
+        if: startsWith(github.ref, 'refs/tags/')
+        with:
+          token: ${{ secrets.GITHUB_TOKEN }}
+          files: "packages/*.${{ matrix.ARTIFACT_EXT }}"