fix: avoid paying fee with staking related transfers

Signed-off-by: Jeremy Letang <[email protected]>

core/banking/fee_estimate.go

@@ -31,9 +31,10 @@ func EstimateFee(
 	fromAccountType types.AccountType,
 	fromDerivedKey *string,
 	to string,
+	toAccountType types.AccountType,
 ) (fee *num.Uint, discount *num.Uint) {
 	tFee := calculateFeeForTransfer(assetQuantum, maxQuantumAmount, transferFeeFactor, amount, from,
-		fromAccountType, fromDerivedKey, to)
+		fromAccountType, fromDerivedKey, to, toAccountType)
 	return calculateDiscount(accumulatedDiscount, tFee)
 }
 
@@ -46,12 +47,15 @@ func calculateFeeForTransfer(
 	fromAccountType types.AccountType,
 	fromDerivedKey *string,
 	to string,
+	toAccountType types.AccountType,
 ) *num.Uint {
 	feeAmount := num.UintZero()
 
 	// no fee for Vested account
 	// either from owner's vested to their general account or from derived key vested to owner's general account
-	if fromAccountType == types.AccountTypeVestedRewards && (from == to || fromDerivedKey != nil) {
+	if (fromAccountType == types.AccountTypeVestedRewards && (from == to || fromDerivedKey != nil)) ||
+		(fromAccountType == types.AccountTypeLockedForStaking && from == to) ||
+		(fromAccountType == types.AccountTypeGeneral && toAccountType == types.AccountTypeLockedForStaking && from == to) {
 		return feeAmount
 	}
 

core/banking/oneoff_transfers.go

@@ -93,7 +93,7 @@ func (e *Engine) updateStakingAccounts(
 			BlockHeight:     height,
 			BlockTime:       now,
 			LogIndex:        1,
-			EthereumAddress: transfer.From,
+			EthereumAddress: "",
 		}
 	}
 
@@ -112,7 +112,7 @@ func (e *Engine) updateStakingAccounts(
 			BlockHeight:     height,
 			BlockTime:       now,
 			LogIndex:        1,
-			EthereumAddress: transfer.From,
+			EthereumAddress: "",
 		}
 	}
 

core/banking/recurring_transfers.go

@@ -321,7 +321,7 @@ func (e *Engine) distributeRecurringTransfers(ctx context.Context, newEpoch uint
 			)
 		} else {
 			// check if the amount + fees can be covered by the party issuing the transfer
-			if err = e.ensureFeeForTransferFunds(a, amount, v.From, v.FromAccountType, v.FromDerivedKey, v.To); err == nil {
+			if err = e.ensureFeeForTransferFunds(a, amount, v.From, v.FromAccountType, v.FromDerivedKey, v.To, v.ToAccountType); err == nil {
 				// NB: if the metric is market value we're going to transfer the bonus if any directly
 				// to the market account of the asset/reward type - this is similar to previous behaviour and
 				// different to how all other metric based rewards behave. The reason is that we need the context of the funder

core/banking/transfers_common.go

@@ -95,7 +95,7 @@ func (e *Engine) CheckTransfer(t *types.TransferBase) error {
 		return err
 	}
 
-	if err = e.ensureFeeForTransferFunds(a, t.Amount, t.From, t.FromAccountType, t.FromDerivedKey, t.To); err != nil {
+	if err = e.ensureFeeForTransferFunds(a, t.Amount, t.From, t.FromAccountType, t.FromDerivedKey, t.To, t.ToAccountType); err != nil {
 		return fmt.Errorf("could not transfer funds, %w", err)
 	}
 	return nil
@@ -166,7 +166,7 @@ func (e *Engine) processTransfer(
 
 	// ensure the party have enough funds for both the
 	// amount and the fee for the transfer
-	feeTransfer, discount, err := e.makeFeeTransferForFundsTransfer(ctx, assetType, amount, from, fromAcc, fromDerivedKey, to)
+	feeTransfer, discount, err := e.makeFeeTransferForFundsTransfer(ctx, assetType, amount, from, fromAcc, fromDerivedKey, to, toAcc)
 	if err != nil {
 		return nil, fmt.Errorf("could not pay the fee for transfer: %w", err)
 	}
@@ -249,6 +249,7 @@ func (e *Engine) calculateFeeTransferForTransfer(
 	fromAccountType types.AccountType,
 	fromDerivedKey *string,
 	to string,
+	toAccountType types.AccountType,
 ) *num.Uint {
 	return calculateFeeForTransfer(
 		asset.Details.Quantum,
@@ -259,6 +260,7 @@ func (e *Engine) calculateFeeTransferForTransfer(
 		fromAccountType,
 		fromDerivedKey,
 		to,
+		toAccountType,
 	)
 }
 
@@ -270,8 +272,9 @@ func (e *Engine) makeFeeTransferForFundsTransfer(
 	fromAccountType types.AccountType,
 	fromDerivedKey *string,
 	to string,
+	toAccountType types.AccountType,
 ) (*types.Transfer, *num.Uint, error) {
-	theoreticalFee := e.calculateFeeTransferForTransfer(asset, amount, from, fromAccountType, fromDerivedKey, to)
+	theoreticalFee := e.calculateFeeTransferForTransfer(asset, amount, from, fromAccountType, fromDerivedKey, to, toAccountType)
 	feeAmount, discountAmount := e.ApplyFeeDiscount(ctx, asset.ID, from, theoreticalFee)
 
 	if err := e.ensureEnoughFundsForTransfer(asset, amount, from, fromAccountType, fromDerivedKey, feeAmount); err != nil {
@@ -306,9 +309,10 @@ func (e *Engine) ensureFeeForTransferFunds(
 	fromAccountType types.AccountType,
 	fromDerivedKey *string,
 	to string,
+	toAccountType types.AccountType,
 ) error {
 	assetType := asset.ToAssetType()
-	theoreticalFee := e.calculateFeeTransferForTransfer(assetType, amount, from, fromAccountType, fromDerivedKey, to)
+	theoreticalFee := e.calculateFeeTransferForTransfer(assetType, amount, from, fromAccountType, fromDerivedKey, to, toAccountType)
 	feeAmount, _ := e.EstimateFeeDiscount(assetType.ID, from, theoreticalFee)
 	return e.ensureEnoughFundsForTransfer(assetType, amount, from, fromAccountType, fromDerivedKey, feeAmount)
 }

core/types/staking.go

@@ -141,6 +141,10 @@ func (s *StakeLinking) IntoProto() *eventspb.StakeLinking {
 
 func StakeLinkingFromProto(sl *eventspb.StakeLinking) *StakeLinking {
 	amt, _ := num.UintFromString(sl.Amount, 10)
+	var ethereumAddress string
+	if len(sl.EthereumAddress) > 0 {
+		ethereumAddress = crypto.EthereumChecksumAddress(sl.EthereumAddress)
+	}
 	return &StakeLinking{
 		ID:              sl.Id,
 		Type:            sl.Type,
@@ -153,7 +157,7 @@ func StakeLinkingFromProto(sl *eventspb.StakeLinking) *StakeLinking {
 		BlockHeight:     sl.BlockHeight,
 		BlockTime:       sl.BlockTime,
 		LogIndex:        sl.LogIndex,
-		EthereumAddress: crypto.EthereumChecksumAddress(sl.EthereumAddress),
+		EthereumAddress: ethereumAddress,
 	}
 }
 

core/vesting/engine.go

@@ -217,7 +217,7 @@ func (e *Engine) updateStakingAccount(
 		BlockHeight:     height,
 		BlockTime:       now,
 		LogIndex:        logIndex,
-		EthereumAddress: party,
+		EthereumAddress: "",
 	}
 
 	e.stakeAccounting.AddEvent(context.Background(), stakeLinking)

datanode/api/trading_data_v2.go

@@ -5728,6 +5728,8 @@ func (t *TradingDataServiceV2) EstimateTransferFee(ctx context.Context, req *v2.
 		req.FromAccountType,
 		req.FromAmmKey,
 		req.ToAccount,
+		// irrelvant here
+		vega.AccountType_ACCOUNT_TYPE_UNSPECIFIED,
 	)
 
 	return &v2.EstimateTransferFeeResponse{