chore: improve market proposal #169
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zale144
approved these changes
Oct 13, 2022
market/service.go
Outdated
| LogNormal: &vega.LogNormalRiskModel{ | ||
| RiskAversionParameter: 0.01, | ||
| Tau: 0.0001140771161, | ||
| Params: &vega.LogNormalModelParams{ |
There was a problem hiding this comment.
Should these numbers be configurable, depending on the market?
There was a problem hiding this comment.
yes, they should at some point in the future. But for now let them keep hardcoded, cos there is much more config parameters that should also be exposed.
fkondej
force-pushed
the
improve-market-proposal
branch
from
ae87729
to
da844ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.