Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#9480): apply single quote escape for the transforms from timeUnit bandPosition #9479

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yhoonkim
Copy link
Contributor

@yhoonkim yhoonkim commented Nov 23, 2024

PR Description

Fixes the issue of timeunit band position transforms which don't escape the field name correctly.

#9480

@yhoonkim yhoonkim requested a review from a team as a code owner November 23, 2024 00:39
Copy link

cloudflare-workers-and-pages bot commented Nov 23, 2024

Deploying vega-lite with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5665cc9
Status: ✅  Deploy successful!
Preview URL: https://a7e75a40.vega-lite.pages.dev
Branch Preview URL: https://fix-timeunitbandpositionexpr.vega-lite.pages.dev

View logs

@yhoonkim yhoonkim requested a review from kanitw November 23, 2024 00:39
@domoritz
Copy link
Member

Can you link to the issue?

@yhoonkim
Copy link
Contributor Author

Can you link to the issue?

Done! (edited the PR description)

@yhoonkim yhoonkim changed the title apply single quote escape fix: apply single quote escape for the transforms from timeUnit bandPosition Nov 23, 2024
@domoritz
Copy link
Member

If you say "fixes" or "closes" before it, GitHub will link it and auto close the issue when the pull request is merged.

@yhoonkim yhoonkim changed the title fix: apply single quote escape for the transforms from timeUnit bandPosition fix(#9480): apply single quote escape for the transforms from timeUnit bandPosition Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants