Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update code to not need implicit any, add hasProperty util #9394

Merged
merged 26 commits into from
Aug 2, 2024
Merged

feat: update code to not need implicit any, add hasProperty util #9394

merged 26 commits into from
Aug 2, 2024

Conversation

domoritz
Copy link
Member

@domoritz domoritz commented Jul 28, 2024 •
edited
Loading

  • update deps including typescript
  • fix a few issues along the way
  • improve code robustness for example for type checks and index accesses
  • remove need for suppressImplicitAnyIndexErrors
  • introduces new utility method hasProperty which checks whether the object has the property and it's not undefined

@domoritz domoritz requested a review from a team as a code owner July 28, 2024 18:05
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jul 28, 2024 •
edited
Loading

Deploying vega-lite with  Cloudflare Pages  Cloudflare Pages

Latest commit: a411340
Status: ✅  Deploy successful!
Preview URL: https://6ce32390.vega-lite.pages.dev
Branch Preview URL: https://dom-updates-7234909.vega-lite.pages.dev

View logs

@domoritz domoritz changed the title chore: update deps fix: update deps including typescript, fix a few issues along the way, and improve code robustness, remove need for suppressImplicitAnyIndexErrors Jul 31, 2024
@domoritz domoritz changed the title fix: update deps including typescript, fix a few issues along the way, and improve code robustness, remove need for suppressImplicitAnyIndexErrors fix: update code to not need implicit any Jul 31, 2024
@domoritz domoritz changed the title fix: update code to not need implicit any feat: update code to not need implicit any, add hasProperty util Aug 1, 2024
@domoritz domoritz requested review from kanitw and lsh August 1, 2024 13:45
lsh
lsh approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@lsh lsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strongly in favor of these changes. This gives us a roadmap of where we can improve on types in the future.

@domoritz domoritz enabled auto-merge (squash) August 2, 2024 01:32
@domoritz domoritz merged commit 6ce344e into main Aug 2, 2024
8 checks passed
@domoritz domoritz deleted the dom/updates-7234909 branch August 2, 2024 01:36
kanitw
kanitw reviewed Oct 11, 2024
View reviewed changes
test/example.test.ts
);
expect(s).toBeDefined();

console.log(JSON.stringify(s));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lsh @domoritz Was this console.log intended? It's polluting the test output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanitw kanitw kanitw left review comments

@lsh lsh lsh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@domoritz @kanitw @lsh