Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make search button more prominent. #144

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Conversation

cjcenizal
Copy link
Collaborator

This PR also expands the size of modal and fixes the dark mode colors. It doesn't add support for dark mode, which is tracked by #136.

image

@cjcenizal cjcenizal changed the base branch from feat/ENG-896_docusaurus_search_plugin to main November 1, 2023 22:38
Copy link

netlify bot commented Nov 1, 2023

Deploy Preview for luxury-shortbread-acee05 ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/luxury-shortbread-acee05/deploys/6542d5248fec0a454811d21f
😎 Deploy Preview https://deploy-preview-144--luxury-shortbread-acee05.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cjcenizal cjcenizal merged commit 8d97d03 into main Nov 1, 2023
4 of 5 checks passed
@cjcenizal cjcenizal deleted the feature/prominent-search branch November 1, 2023 22:51
pwoznic pushed a commit to pwoznic/vectara-docs that referenced this pull request Nov 3, 2023
Expand size of modal. Fix dark mode colors.
pwoznic added a commit that referenced this pull request Nov 3, 2023
* Replace Grounded Generation with Retrieval Augmented Generation

Updated topics to refer to RAG instead of GG

* Fix typos

* feat: Implement search plugin in local folder (#132)

* feat: Implement search plugin in local folder

* feat: Add support for ctrl + k to open search

* chore: Remove CSS reset and test page

* chore: Reorganized scss imports

* Move key handler inside of useEffect

* fix: Re-rerender search on page navigation

* Make search button more prominent. (#144)

Expand size of modal. Fix dark mode colors.

* Added Snow Analytics code. (#146)

* Added Snow Analytics code.

* Addressed one code review comment.

---------

Co-authored-by: Aamir Butt <[email protected]>

* Add TopicButton, Grid, and Spacer components. (#147)

* Fix dependencies.

* Update welcome.mdx

Renamed GG to RAG

---------

Signed-off-by: Paul Wozniczka <[email protected]>
Co-authored-by: mrderyk <[email protected]>
Co-authored-by: CJ Cenizal <[email protected]>
Co-authored-by: aamirbutt <[email protected]>
Co-authored-by: Aamir Butt <[email protected]>
pwoznic pushed a commit to pwoznic/vectara-docs that referenced this pull request Nov 7, 2023
Expand size of modal. Fix dark mode colors.
pwoznic added a commit to pwoznic/vectara-docs that referenced this pull request Nov 7, 2023
…ara#143)

* Replace Grounded Generation with Retrieval Augmented Generation

Updated topics to refer to RAG instead of GG

* Fix typos

* feat: Implement search plugin in local folder (vectara#132)

* feat: Implement search plugin in local folder

* feat: Add support for ctrl + k to open search

* chore: Remove CSS reset and test page

* chore: Reorganized scss imports

* Move key handler inside of useEffect

* fix: Re-rerender search on page navigation

* Make search button more prominent. (vectara#144)

Expand size of modal. Fix dark mode colors.

* Added Snow Analytics code. (vectara#146)

* Added Snow Analytics code.

* Addressed one code review comment.

---------

Co-authored-by: Aamir Butt <[email protected]>

* Add TopicButton, Grid, and Spacer components. (vectara#147)

* Fix dependencies.

* Update welcome.mdx

Renamed GG to RAG

---------

Signed-off-by: Paul Wozniczka <[email protected]>
Co-authored-by: mrderyk <[email protected]>
Co-authored-by: CJ Cenizal <[email protected]>
Co-authored-by: aamirbutt <[email protected]>
Co-authored-by: Aamir Butt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants