Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Seed in ModelParams for Summarization Requests #39

Merged
merged 10 commits into from
Aug 15, 2024
Merged

Added Seed in ModelParams for Summarization Requests #39

merged 10 commits into from
Aug 15, 2024

Conversation

faiqibrahim
Copy link
Contributor

Heads up!

These protobufs in this repository are automatically generated from Vectara and
the repository is read-only for the general public. As a result, we do not
accept pull requests to this GitHub repository.

If you have feedback on Vectara or its APIs, please let us know in our
forums: https://discuss.vectara.com/

@tallatshafaat
Copy link
Collaborator

I don't know what's up with permission changes to these proto files.

Copy link
Collaborator

@tallatshafaat tallatshafaat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what's up with these proto file permission changes.

From my side, this is good. @pwoznic whenever you're ready to make this public, please approve and merge. Thanks.

serving.proto Outdated
}
ModelParams model_params = 215;

// Parameters for the citation style.
CitationParams citation_params = 220;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all prompts support citation prompts. @pwoznic we should have a list somewhere in the docs that lists which prompts support this.

Copy link
Contributor

@pwoznic pwoznic Aug 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The citations content lists the supposed prompts (5 at the moment). Edit: Just noticed the date. I think it was addressed in Slack. Was about to merge but just saw a conflict.

@@ -47,6 +47,8 @@ message ApiKey {
optional int64 ts_end = 6;
// Status of the ApiKey.
ApiKeyStatus status = 7;
// An id of the key that is not sensitive.
uint32 public_id = 8;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikron are you okay making this part of the public api? i don't see a reason why not, but just FYI, this is going public.

@pwoznic pwoznic merged commit 6ca406a into main Aug 15, 2024
1 check passed
@nikron nikron deleted the dev branch August 15, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants