Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-lite): display host console #8136

Merged
merged 13 commits into from
Nov 26, 2024
Merged

feat(xo-lite): display host console #8136

merged 13 commits into from
Nov 26, 2024

Conversation

SebastianCzechDev
Copy link
Contributor

@SebastianCzechDev SebastianCzechDev commented Nov 15, 2024

Description

Displaying host console

SCREENSHOT

Capture d’écran 2024-11-25 à 18 05 59

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.

@xen-orchestra/lite/src/views/host/HostNetworkView.vue Outdated Show resolved Hide resolved
@xen-orchestra/lite/src/views/host/HostTasksView.vue Outdated Show resolved Hide resolved
@xen-orchestra/lite/src/views/host/HostVmsView.vue Outdated Show resolved Hide resolved
@xen-orchestra/lite/src/components/host/HostHeader.vue Outdated Show resolved Hide resolved
@xen-orchestra/lite/src/views/host/HostConsoleView.vue Outdated Show resolved Hide resolved
@xen-orchestra/lite/src/views/host/HostConsoleView.vue Outdated Show resolved Hide resolved
@SebastianCzechDev SebastianCzechDev requested review from MathieuRA and removed request for ByScripts November 25, 2024 13:22
MathieuRA

This comment was marked as resolved.

CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
@OlivierFL OlivierFL merged commit 904273f into master Nov 26, 2024
1 check passed
@OlivierFL OlivierFL deleted the display-console-to-host branch November 26, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants