Add exponential backoff for requests that receive PV drivers missing error #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 9f22000)
ddelnano
deleted the
ddelnano/add-exp-backoff-to-retryable-xo-api-requests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Add exponential backoff for requests that receive PV drivers missing error
This PR is aimed at fixing some issues seen when running the acceptance test suite in Jenkins. There are times where an acceptance test that performs hot plugging of devices tries to attach or disconnect devices before the guest's has fully booted and had its PV drivers initialized. This is one of the changes needed to stabilize the build for #264.
In order to address this, the XO client has been augmented to provide a mechanism for retrying specific JSON rpc error codes and opting the "missing PV drivers" condition into this behavior.
Testing done: