Rebased upstream xo sdk #176
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ringo De Smet <[email protected]>
Signed-off-by: Ringo De Smet <[email protected]>
|
@ringods sorry that your change was made just as I needed to revert some code in the xo client. Please see the related review, but it's probably easiest for us to use this branch (since yours needed a rebase). |
|
@ddelnano no problem. I just approved and merged your PR in the XO sdk repo. |
…ield that causes problems)
|
I'll run the terraform acceptance tests once more to verify this is good and then I'll merge this. |
|
Closing this due to the conversation on vatesfr/xo-sdk-go#5. I'll happily revisit it and upstream changes there if need be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebased version of #174 due to #175. It was tested locally with vatesfr/xo-sdk-go#4.
Todo
go.modfile once Remove nic_type support from the XO client since it was causing test failures xo-sdk-go#4 is merged