Add Subreddit Comment Support #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RGood
commented
Mar 7, 2021
|
|
||
| // certain comment streams are inconsistent about the completeness of returned comments | ||
| // it's not enough to check if we've seen older comments, but we must check for every comment individually | ||
| if !ids.Exists(id) { |
There was a problem hiding this comment.
This ids set should probably get cleaned up at some point for continuously-running streams, or else it could cause memory problems in long-running apps
|
Closed, as the changes are rolled up into #12 May as well just merge them together. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
subreddit.goto support fetching comments via Listingstream.goto produce a stream of comments from a subreddit using this method