Feat/make tools as packages #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angrybayblade
approved these changes
Dec 13, 2023
| @@ -28,8 +28,9 @@ class AnyToolAsTask: | |||
| def execute(self, *args: Any, **kwargs: Any) -> Any: | |||
| """Execute the task.""" | |||
| tool_py = kwargs.pop("tool_py") | |||
| if "run" in globals(): | |||
| del globals()["run"] | |||
| callable_method = kwargs.pop("callable_method") | |||
There was a problem hiding this comment.
Is this going to work with multiple packages having the same callable name?
There was a problem hiding this comment.
all tools had run as their callable and it worked
There was a problem hiding this comment.
@0xArdi one comment - ow looks good
please check for each package who the author was. In some cases it’s not Valory
jmoreira-valory
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for having tools as custom packages.