Package dependencies update and goerli to legacy #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kupermind
commented
Nov 5, 2024
| @@ -15,10 +15,8 @@ jobs: | |||
| with: | |||
| submodules: recursive | |||
|
|
|||
| - name: Get a specific Node.js version such that hardhat does not hang periodically | |||
There was a problem hiding this comment.
This no longer works, need to get v18.20, and the bug seems to be fixed a long time ago.
kupermind
commented
Nov 5, 2024
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "autonolas-tokenomics", | |||
| "version": "1.0.0", | |||
There was a problem hiding this comment.
Adjusting to the Tokenomics contract version
kupermind
commented
Nov 5, 2024
Comment on lines
-59
to
-63
| "cross-fetch": "^4.0.0", | ||
| "eth-permit": "^0.2.3", | ||
| "ethereum-sources-downloader": "^0.1.21", | ||
| "node-fetch": "^3.3.2", | ||
| "scribble-generator": "^1.1.0", |
There was a problem hiding this comment.
These are not explicitly needed, scribble needs to be installed as a global env anyway if anybody wants to run it.
kupermind
commented
Nov 5, 2024
| @@ -5,7 +5,7 @@ These scripts correspond to the steps in the full deployment procedure (as descr | |||
| For the Tokenomics 1.2, refer to the following deployment procedure: [deployment_v1.2.md](https://github.com/valory-xyz/autonolas-tokenomics/blob/main/docs/deployment_v1.2.md). | |||
|
|
|||
| ## Observations | |||
| - There are several files with global parameters based on the corresponding network. In order to work with the configuration, please copy `gobals_network.json` file to file the `gobals.json` one, where `network` is the corresponding network. For example: `cp gobals_goerli.json gobals.json`. | |||
There was a problem hiding this comment.
The rest is just putting goerli mentioning in text to legacy
77ph
approved these changes
Nov 5, 2024
DavidMinarsch
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
goerlimentioning to legacy;