refactor: addressing interim internal audit findings #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kupermind
commented
Jul 29, 2024
kupermind
commented
- Addressing interim internal audit findings;
- Adjusting tests.
refactor and test: addressing C4R issue 26
chore: update tokenomics implementation address
…incentives for removed nominee epoch
chore: testing bridge interactions
V1.2.2 internal audit
refactor: addressing C4R issues 56 and 27
refactor and test: addressing C4R issue 38
refactor and test: addressing C4R issue 61
refactor: addressing C4R issue 67
refactor and test: addressing C4R issues 32 and 5
refactor: addressing C4R issues 45 and 4
refactor: addressing C4R issue 29
refactor and test: addressing issue 20
refactor and test: addressing C4R issue 22
doc: catch up on changes
chore: adding scripts to update owners on L2
chore: staking deployment scripts
kupermind
commented
Aug 1, 2024
| @@ -225,6 +227,17 @@ contract Depository is ERC721, IErrorsTokenomics { | |||
| } | |||
| } | |||
|
|
|||
| /// @dev Sets minimum OLAS leftover amount for the product to keep the supply. | |||
| /// @param _minOLASLeftoverAmount Updated minimum OLAS leftover amount. | |||
| function setMinOLASLeftoverAmount(uint256 _minOLASLeftoverAmount) external { | |||
There was a problem hiding this comment.
Maybe need to add a variable in the constructor as well.
kupermind
commented
Aug 1, 2024
| uint256 totalDonationPower = mapDonationPoints[epochNum].totalDonationPower; | ||
| totalIncentives *= totalTopUpsOLAS * mapEpochTokenomics[epochNum].unitPoints[unitType].topUpUnitFraction; | ||
| totalIncentives = mapUnitIncentives[unitType][unitId].topUp + (totalIncentives / (totalDonationPower * 100)); | ||
| // topUp = (pendingRelativeTopUp * totalUnitTopUps * topUpUnitFraction) / sumTopUpUnitFractions, if totalDonationPower > totalUnitTopUps |
There was a problem hiding this comment.
Adjusted calculations according to the doc, tests prove their correctness.
kupermind
commented
Aug 1, 2024
| } | ||
| mapDonationPoints[eCounter].totalDonationPower = uint96(accountTopUps); | ||
|
|
||
| // Record total unit top-ups and fractions in a settled epoch |
There was a problem hiding this comment.
totalUnitTopUps and the sum of fractions need to be recorded. The total veOLAS donation power is recorded throughout the epoch in the tracking function.
DavidMinarsch
approved these changes
Aug 3, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.