Skip to content

Commit

Permalink
Merge pull request #183 from valory-xyz/v1.3.0-internal-audit2
Browse files Browse the repository at this point in the history
doc: re-audit
  • Loading branch information
DavidMinarsch authored Aug 3, 2024
2 parents 1417b2d + 88f30e8 commit 38ebd10
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 0 deletions.
32 changes: 32 additions & 0 deletions audits/internal6/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,3 +66,35 @@ Moreover, according to calculations discountBooster <= 1e18 << max(epsilonRate)
```
[x] IDF is never bigger than 2e18 by design

### Re-audit 02.08.24
The review has been performed based on the contract code in the following repository:<br>
`https://github.com/valory-xyz/autonolas-tokenomics` <br>
commit: `c76a04a64fd450e1a7a34873ea49b6a4b4b0b856` or `tag: v1.3.0-internal-audit2`<br>

### Coverage
```
---------------------------------|----------|----------|----------|----------|----------------|
File | % Stmts | % Branch | % Funcs | % Lines |Uncovered Lines |
---------------------------------|----------|----------|----------|----------|----------------|
contracts/ | 98.83 | 96.45 | 95.51 | 97.79 | |
BondCalculator.sol | 97.44 | 98 | 85.71 | 97.22 | 181,299 |
Depository.sol | 95.56 | 92.71 | 81.25 | 93.49 |... 605,608,615 |
Dispenser.sol | 98.95 | 93.06 | 100 | 96.24 |... 0,1209,1267 |
---------------------------------|----------|----------|----------|----------|----------------|
```
Please, pay attention.

### Storage and proxy
Using sol2uml tools: https://github.com/naddison36/sol2uml <br>
```
npm link sol2uml --only=production
sol2uml storage contracts/ -f png -c Tokenomics -o audits/internal6/analysis/storage
Generated png file audits/internal6/analysis/storage/Tokenomics.png
```
[Tokenomics-storage](https://github.com/valory-xyz/autonolas-tokenomics/blob/main/audits/internal6/analysis/storage/Tokenomics.png) <br>
current deployed: <br>
[Tokenomics-storage-current](https://github.com/valory-xyz/autonolas-tokenomics/blob/main/audits/internal4/analysis/storage/Tokenomics.png) <br>
The new slot allocation for Tokenomics (critical as proxy pattern) does not affect the previous one.

### Issue
I don't see any problems.
Binary file modified audits/internal6/analysis/storage/Tokenomics.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 38ebd10

Please sign in to comment.