Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sortable): unsubscribe item capture when component is destroyed #6546

Open
wants to merge 6 commits into
base: development
Choose a base branch
from

Merge branch 'development' into fix-memory-leaks

b98712f
Select commit
Loading
Failed to load commit list.
Open

fix(sortable): unsubscribe item capture when component is destroyed #6546

Merge branch 'development' into fix-memory-leaks
b98712f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 22, 2024 in 0s

76.59% (-0.01%) compared to e77c928, passed because coverage increased by 0% when compared to adjusted base (76.59%)

View this Pull Request on Codecov

76.59% (-0.01%) compared to e77c928, passed because coverage increased by 0% when compared to adjusted base (76.59%)

Details

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 76.59%. Comparing base (e77c928) to head (b98712f).
Report is 1 commits behind head on development.

Files with missing lines Patch % Lines
src/sortable/sortable.component.ts 42.85% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6546      +/-   ##
===============================================
- Coverage        76.60%   76.59%   -0.01%     
===============================================
  Files              317      317              
  Lines            10748    10754       +6     
  Branches          2866     2866              
===============================================
+ Hits              8233     8237       +4     
- Misses            2514     2516       +2     
  Partials             1        1              
Files with missing lines Coverage Δ
src/sortable/sortable.component.ts 8.24% <42.85%> (+1.65%) ⬆️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b56863d...b98712f. Read the comment docs.