feat(ssr-docs); merged development

valor-software · Dec 17, 2024 · bbc3478 · bbc3478
1 parent a67c0a9
commit bbc3478
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 9 deletions.
diff --git a/.github/workflows/on-push-or-pull.yml b/.github/workflows/on-push-or-pull.yml
@@ -151,7 +151,7 @@ jobs:
 
       - name: smoke e2e on firebase
         if: ${{ needs.firebase_preview.outputs.output_url }}
-        run:  PLAYWRIGHT_TEST_BASE_URL="${{ needs.firebase_preview.outputs.output_url }}/ngx-bootstrap/" npx nx run ngx-bootstrap-docs-e2e:e2e --pwProject=chromium-integration --shard=${{ matrix.shard }}/${{ strategy.job-total }}
+        run: PLAYWRIGHT_TEST_BASE_URL="${{ needs.firebase_preview.outputs.output_url }}/ngx-bootstrap/" npx nx run ngx-bootstrap-docs-e2e:e2e --pwProject=chromium-integration --skipServe --shard=${{ matrix.shard }}/${{ strategy.job-total }}
 
       - name: smoke e2e local
         if: ${{ !needs.firebase_preview.outputs.output_url }}

diff --git a/apps/ngx-bootstrap-docs-e2e/playwright.config.ts b/apps/ngx-bootstrap-docs-e2e/playwright.config.ts
@@ -5,9 +5,7 @@ export default defineConfig({
   testMatch: '**/*.spec.ts',
   fullyParallel: true,
   workers: 3,
-  expect: {
-    timeout: 30000
-  },
+
   reporter: [['html', { outputFolder: 'playwright-report', open: 'never' }]],
   use: {
     baseURL: process.env['PLAYWRIGHT_TEST_BASE_URL'] || 'http://localhost:4200/ngx-bootstrap/',

diff --git a/apps/ngx-bootstrap-docs-e2e/src/support/accordion.po.ts b/apps/ngx-bootstrap-docs-e2e/src/support/accordion.po.ts
@@ -38,9 +38,6 @@ export class AccordionPo extends BasePo {
   }
 
   async clickOnAccordionGroup(baseSelector: string, itemIndex: number) {
-    await this.page
-      .locator(baseSelector + ' accordion-group button')
-      .nth(itemIndex).waitFor({state: 'visible'});
     await this.page
       .locator(baseSelector + ' accordion-group button')
       .nth(itemIndex)

diff --git a/src/datepicker/testing/bs-inline-datepicker-minmode-year.spec.ts b/src/datepicker/testing/bs-inline-datepicker-minmode-year.spec.ts
@@ -14,7 +14,7 @@ import { getYearsCalendarInitialDate } from '../utils/bs-calendar-utils';
 
 @Component({
     selector: 'test-cmp',
-    template: `<bs-datepicker-inline [bsConfig]="bsConfig"></bs-datepicker-inline>>`,
+    template: `<bs-datepicker-inline [bsConfig]="bsConfig"></bs-datepicker-inline>`,
     standalone: true
 })
 class TestComponent {

diff --git a/src/datepicker/testing/bs-inline-datepicker.spec.ts b/src/datepicker/testing/bs-inline-datepicker.spec.ts
@@ -13,7 +13,7 @@ import { getYearsCalendarInitialDate } from '../utils/bs-calendar-utils';
 
 @Component({
     selector: 'test-cmp',
-    template: `<bs-datepicker-inline [bsConfig]="bsConfig"></bs-datepicker-inline>>`,
+    template: `<bs-datepicker-inline [bsConfig]="bsConfig"></bs-datepicker-inline>`,
     standalone: false
 })
 class TestComponent {