Chore : Upgrade Angular 18 (#6653)

* chore: update NX 19 and Angular 18 * fix: linting error , exclude spec --------- Co-authored-by: Matthias_Huygelen <[email protected]>
valor-software · Jun 17, 2024 · 322af2b · 322af2b
1 parent 5c52605
commit 322af2b
Show file tree

Hide file tree

Showing 60 changed files with 8,357 additions and 7,274 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -1,20 +1,12 @@
 {
   "root": true,
-  "ignorePatterns": [
-    "**/*"
-  ],
-  "plugins": [
-    "@nx"
-  ],
+  "ignorePatterns": ["**/*"],
+  "plugins": ["@nx"],
   "rules": {},
   "overrides": [
     {
-      "files": [
-        "*.ts",
-        "*.tsx",
-        "*.js",
-        "*.jsx"
-      ],
+      "files": ["*.ts", "*.tsx", "*.js", "*.jsx"],
+      "excludedFiles": ["*.spec.ts"],
       "rules": {
         "@nx/enforce-module-boundaries": [
           "error",
@@ -24,42 +16,33 @@
             "depConstraints": [
               {
                 "sourceTag": "*",
-                "onlyDependOnLibsWithTags": [
-                  "*"
-                ]
+                "onlyDependOnLibsWithTags": ["*"]
               }
             ]
           }
         ]
       }
     },
     {
-      "files": [
-        "*.ts",
-        "*.tsx"
-      ],
-      "extends": [
-        "plugin:@nx/typescript"
-      ],
+      "files": ["*.ts", "*.tsx"],
+      "extends": ["plugin:@nx/typescript"],
       "parserOptions": {
         "project": "./tsconfig.*?.json"
       },
       "rules": {
         "semi": "off",
-        "@typescript-eslint/semi": [
-          "error"
-        ]
+        "@typescript-eslint/semi": ["error"],
+        "@typescript-eslint/no-extra-semi": "error",
+        "no-extra-semi": "off"
       }
     },
     {
-      "files": [
-        "*.js",
-        "*.jsx"
-      ],
-      "extends": [
-        "plugin:@nx/javascript"
-      ],
-      "rules": {}
+      "files": ["*.js", "*.jsx"],
+      "extends": ["plugin:@nx/javascript"],
+      "rules": {
+        "@typescript-eslint/no-extra-semi": "error",
+        "no-extra-semi": "off"
+      }
     }
   ]
 }
diff --git a/.gitignore b/.gitignore
@@ -8,6 +8,7 @@
 
 # dependencies
 /node_modules
+src/root/node_modules
 
 # IDEs and editors
 /.idea

diff --git a/README.md b/README.md
@@ -179,6 +179,7 @@ Here is the version compatibility list:
 
 | ngx-bootstrap | Angular         | Bootstrap CSS           |
 | ------------- | --------------- | ----------------------- |
+| 13.x.x        | 18.x.x          | 5.x.x or 4.x.x          |
 | 12.x.x        | 17.x.x          | 5.x.x or 4.x.x          |
 | 11.x.x        | 16.x.x          | 5.x.x or 4.x.x          |
 | 10.x.x        | 15.x.x          | 5.x.x or 4.x.x          |

diff --git a/apps/ngx-bootstrap-docs-e2e/project.json b/apps/ngx-bootstrap-docs-e2e/project.json
@@ -3,6 +3,8 @@
   "$schema": "../../node_modules/nx/schemas/project-schema.json",
   "sourceRoot": "apps/ngx-bootstrap-docs-e2e/src",
   "projectType": "application",
+  "tags": [],
+  "implicitDependencies": ["ngx-bootstrap-docs"],
   "targets": {
     "e2e": {
       "executor": "@nxkit/playwright:test",
@@ -44,12 +46,7 @@
     },
     "lint": {
       "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputPath}"],
-      "options": {
-        "lintFilePatterns": ["apps/ngx-bootstrap-docs-e2e/**/*.{js,ts}"]
-      }
+      "outputs": ["{options.outputPath}"]
     }
-  },
-  "tags": [],
-  "implicitDependencies": ["ngx-bootstrap-docs"]
+  }
 }
diff --git a/apps/ngx-bootstrap-docs/.eslintrc.json b/apps/ngx-bootstrap-docs/.eslintrc.json
@@ -3,7 +3,8 @@
     "../../.eslintrc.json"
   ],
   "ignorePatterns": [
-    "!**/*"
+    "!**/*",
+    "**/assets/**"
   ],
   "overrides": [
     {

diff --git a/apps/ngx-bootstrap-docs/project.json b/apps/ngx-bootstrap-docs/project.json
@@ -4,6 +4,7 @@
   "projectType": "application",
   "sourceRoot": "apps/ngx-bootstrap-docs/src",
   "prefix": "ngx-bootstrap-base",
+  "implicitDependencies": ["ngx-bootstrap"],
   "targets": {
     "build": {
       "executor": "@angular-devkit/build-angular:browser",
@@ -87,11 +88,7 @@
       }
     },
     "lint": {
-      "executor": "@nx/eslint:lint",
-      "options": {
-        "lintFilePatterns": ["apps/ngx-bootstrap-docs/src/**/*.ts", "apps/ngx-bootstrap-docs/src/**/*.html"]
-      }
+      "executor": "@nx/eslint:lint"
     }
-  },
-  "implicitDependencies": ["ngx-bootstrap"]
+  }
 }
diff --git a/apps/ngx-bootstrap-docs/src/app/app.module.ts b/apps/ngx-bootstrap-docs/src/app/app.module.ts
@@ -1,4 +1,4 @@
-import { HttpClientModule } from '@angular/common/http';
+import { provideHttpClient, withInterceptorsFromDi } from '@angular/common/http';
 import { NgModule } from '@angular/core';
 import { RouterModule } from '@angular/router';
 import { BsDropdownModule } from 'ngx-bootstrap/dropdown';
@@ -10,22 +10,17 @@ import { AppComponent } from './app.component';
 import { DOCS_TOKENS, DocsModule, NgApiDoc, SIDEBAR_ROUTES, SidebarRoutesStructure } from '@ngx-bootstrap-doc/docs';
 import { routes } from './app.routing';
 
-@NgModule({
-  declarations: [
-    AppComponent
-  ],
-  imports: [
-    BrowserAnimationsModule,
-    DocsModule,
-    HttpClientModule,
-    RouterModule.forRoot(routes, { useHash: environment.useHash }),
-    BsDropdownModule.forRoot()
-  ],
-  providers: [
-    { provide: NgApiDoc, useValue: ngdoc },
-    { provide: DOCS_TOKENS, useValue: routes },
-    { provide: SIDEBAR_ROUTES, useValue: SidebarRoutesStructure }],
-  bootstrap: [AppComponent]
-})
+@NgModule({ declarations: [
+        AppComponent
+    ],
+    bootstrap: [AppComponent], imports: [BrowserAnimationsModule,
+        DocsModule,
+        RouterModule.forRoot(routes, { useHash: environment.useHash }),
+        BsDropdownModule.forRoot()], providers: [
+        { provide: NgApiDoc, useValue: ngdoc },
+        { provide: DOCS_TOKENS, useValue: routes },
+        { provide: SIDEBAR_ROUTES, useValue: SidebarRoutesStructure },
+        provideHttpClient(withInterceptorsFromDi())
+    ] })
 export class AppModule {
 }
diff --git a/libs/common-docs/project.json b/libs/common-docs/project.json
@@ -24,10 +24,7 @@
       ]
     },
     "lint": {
-      "executor": "@nx/eslint:lint",
-      "options": {
-        "lintFilePatterns": ["libs/common-docs/src/**/*.ts", "libs/common-docs/src/**/*.html"]
-      }
+      "executor": "@nx/eslint:lint"
     }
   }
 }
diff --git a/libs/common-docs/src/lib/common/add-nav/add-nav.component.ts b/libs/common-docs/src/lib/common/add-nav/add-nav.component.ts
@@ -32,7 +32,7 @@ export class AddNavComponent implements OnChanges, AfterViewChecked, AfterViewIn
   @HostListener('window:scroll')
   onScrollEvent() {
     this.initActiveMenuTab();
-  };
+  }
 
   // eslint-disable-next-line @typescript-eslint/no-empty-function
   constructor(

diff --git a/libs/common-docs/src/lib/common/discover/discover.component.ts b/libs/common-docs/src/lib/common/discover/discover.component.ts
@@ -6,7 +6,7 @@ interface ICompany {
   description: string;
   link: string;
   scale?: boolean;
-};
+}
 
 @Component({
   // eslint-disable-next-line @angular-eslint/component-selector

diff --git a/libs/common-docs/src/lib/common/documentation/documentation.component.html b/libs/common-docs/src/lib/common/documentation/documentation.component.html
@@ -232,6 +232,16 @@ <h2 id="compatibility">
           </tr>
         </thead>
         <tbody>
+          <tr>
+            <th>13.x.x</th>
+            <th>18.x.x</th>
+            <th>5.x.x or 4.x.x</th>
+          </tr>
+          <tr>
+            <th>12.x.x</th>
+            <th>17.x.x</th>
+            <th>5.x.x or 4.x.x</th>
+          </tr>
           <tr>
             <th>11.x.x</th>
             <th>16.x.x</th>

diff --git a/libs/doc-pages/accordion/project.json b/libs/doc-pages/accordion/project.json
@@ -25,10 +25,7 @@
       ]
     },
     "lint": {
-      "executor": "@nx/eslint:lint",
-      "options": {
-        "lintFilePatterns": ["libs/doc-pages/accordion/src/**/*.ts", "libs/doc-pages/accordion/src/**/*.html"]
-      }
+      "executor": "@nx/eslint:lint"
     }
   }
 }
diff --git a/libs/doc-pages/alerts/project.json b/libs/doc-pages/alerts/project.json
@@ -24,10 +24,7 @@
       ]
     },
     "lint": {
-      "executor": "@nx/eslint:lint",
-      "options": {
-        "lintFilePatterns": ["libs/doc-pages/alerts/src/**/*.ts", "libs/doc-pages/alerts/src/**/*.html"]
-      }
+      "executor": "@nx/eslint:lint"
     }
   }
 }
diff --git a/libs/doc-pages/buttons/project.json b/libs/doc-pages/buttons/project.json
@@ -24,10 +24,7 @@
       ]
     },
     "lint": {
-      "executor": "@nx/eslint:lint",
-      "options": {
-        "lintFilePatterns": ["libs/doc-pages/buttons/src/**/*.ts", "libs/doc-pages/buttons/src/**/*.html"]
-      }
+      "executor": "@nx/eslint:lint"
     }
   }
 }
diff --git a/libs/doc-pages/carousel/project.json b/libs/doc-pages/carousel/project.json
@@ -24,10 +24,7 @@
       ]
     },
     "lint": {
-      "executor": "@nx/eslint:lint",
-      "options": {
-        "lintFilePatterns": ["libs/doc-pages/carousel/src/**/*.ts", "libs/doc-pages/carousel/src/**/*.html"]
-      }
+      "executor": "@nx/eslint:lint"
     }
   }
 }
diff --git a/libs/doc-pages/collapse/project.json b/libs/doc-pages/collapse/project.json
@@ -24,10 +24,7 @@
       ]
     },
     "lint": {
-      "executor": "@nx/eslint:lint",
-      "options": {
-        "lintFilePatterns": ["libs/doc-pages/collapse/src/**/*.ts", "libs/doc-pages/collapse/src/**/*.html"]
-      }
+      "executor": "@nx/eslint:lint"
     }
   }
 }
diff --git a/libs/doc-pages/datepicker/project.json b/libs/doc-pages/datepicker/project.json
@@ -24,10 +24,7 @@
       ]
     },
     "lint": {
-      "executor": "@nx/eslint:lint",
-      "options": {
-        "lintFilePatterns": ["libs/doc-pages/datepicker/src/**/*.ts", "libs/doc-pages/datepicker/src/**/*.html"]
-      }
+      "executor": "@nx/eslint:lint"
     }
   }
 }
diff --git a/libs/doc-pages/dropdown/project.json b/libs/doc-pages/dropdown/project.json
@@ -24,10 +24,7 @@
       ]
     },
     "lint": {
-      "executor": "@nx/eslint:lint",
-      "options": {
-        "lintFilePatterns": ["libs/doc-pages/dropdown/src/**/*.ts", "libs/doc-pages/dropdown/src/**/*.html"]
-      }
+      "executor": "@nx/eslint:lint"
     }
   }
 }
diff --git a/libs/doc-pages/modal/project.json b/libs/doc-pages/modal/project.json
@@ -24,10 +24,7 @@
       ]
     },
     "lint": {
-      "executor": "@nx/eslint:lint",
-      "options": {
-        "lintFilePatterns": ["libs/doc-pages/modal/src/**/*.ts", "libs/doc-pages/modal/src/**/*.html"]
-      }
+      "executor": "@nx/eslint:lint"
     }
   }
 }
diff --git a/libs/doc-pages/pagination/project.json b/libs/doc-pages/pagination/project.json
@@ -24,10 +24,7 @@
       ]
     },
     "lint": {
-      "executor": "@nx/eslint:lint",
-      "options": {
-        "lintFilePatterns": ["libs/doc-pages/pagination/src/**/*.ts", "libs/doc-pages/pagination/src/**/*.html"]
-      }
+      "executor": "@nx/eslint:lint"
     }
   }
 }
diff --git a/libs/doc-pages/popover/project.json b/libs/doc-pages/popover/project.json
@@ -24,10 +24,7 @@
       ]
     },
     "lint": {
-      "executor": "@nx/eslint:lint",
-      "options": {
-        "lintFilePatterns": ["libs/doc-pages/popover/src/**/*.ts", "libs/doc-pages/popover/src/**/*.html"]
-      }
+      "executor": "@nx/eslint:lint"
     }
   }
 }
diff --git a/libs/doc-pages/progressbar/project.json b/libs/doc-pages/progressbar/project.json
@@ -24,10 +24,7 @@
       ]
     },
     "lint": {
-      "executor": "@nx/eslint:lint",
-      "options": {
-        "lintFilePatterns": ["libs/doc-pages/progressbar/src/**/*.ts", "libs/doc-pages/progressbar/src/**/*.html"]
-      }
+      "executor": "@nx/eslint:lint"
     }
   }
 }
diff --git a/libs/doc-pages/rating/project.json b/libs/doc-pages/rating/project.json
@@ -24,10 +24,7 @@
       ]
     },
     "lint": {
-      "executor": "@nx/eslint:lint",
-      "options": {
-        "lintFilePatterns": ["libs/doc-pages/rating/src/**/*.ts", "libs/doc-pages/rating/src/**/*.html"]
-      }
+      "executor": "@nx/eslint:lint"
     }
   }
 }
diff --git a/libs/doc-pages/sortable/project.json b/libs/doc-pages/sortable/project.json
@@ -24,10 +24,7 @@
       ]
     },
     "lint": {
-      "executor": "@nx/eslint:lint",
-      "options": {
-        "lintFilePatterns": ["libs/doc-pages/sortable/src/**/*.ts", "libs/doc-pages/sortable/src/**/*.html"]
-      }
+      "executor": "@nx/eslint:lint"
     }
   }
 }