Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format with black #122

Merged
merged 3 commits into from
Oct 2, 2023
Merged

Format with black #122

merged 3 commits into from
Oct 2, 2023

Conversation

teroyks
Copy link
Contributor

@teroyks teroyks commented Oct 2, 2023

Resolves #123

Add Black as a pre-commit hook,
run on all existing Python files.

akx

This comment was marked as outdated.

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2023

Codecov Report

Merging #122 (95f4b23) into master (7309111) will decrease coverage by 0.21%.
The diff coverage is 92.48%.

@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
- Coverage   92.49%   92.28%   -0.21%     
==========================================
  Files          61       61              
  Lines        1906     1906              
  Branches      323      323              
==========================================
- Hits         1763     1759       -4     
  Misses         71       71              
- Partials       72       76       +4     
Files Coverage Δ
tests/config_data.py 100.00% <ø> (ø)
tests/conftest.py 100.00% <100.00%> (ø)
tests/consts.py 100.00% <100.00%> (ø)
tests/test_command.py 100.00% <100.00%> (ø)
tests/test_edge.py 100.00% <100.00%> (ø)
tests/test_endpoint_parsing.py 100.00% <100.00%> (ø)
tests/test_get_step_by.py 100.00% <100.00%> (ø)
tests/test_multiple_param.py 100.00% <100.00%> (ø)
tests/test_param_validation.py 100.00% <100.00%> (ø)
tests/test_parsing.py 100.00% <100.00%> (ø)
... and 42 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@teroyks
Copy link
Contributor Author

teroyks commented Oct 2, 2023

Can you again do the --author "Ruff <[email protected]>" dance on the massive reformat commit?

Yes – this first commit was just to test if all the CI rules pass before fixing author (and blame ignore).

valohai-bot and others added 2 commits October 2, 2023 13:01
Use Black as the code formatter,
with Ruff fixes on top.

The Ruff rules are the same as before, but applied to some new files
after the reformatting.
Add `.git-blame-ignore-revs` to local git config with:

git config blame.ignoreRevsFile .git-blame-ignore-revs
@teroyks teroyks force-pushed the tero/taco/format-with-black branch from c894257 to 95f4b23 Compare October 2, 2023 10:10
@teroyks teroyks self-assigned this Oct 2, 2023
@teroyks teroyks linked an issue Oct 2, 2023 that may be closed by this pull request
@teroyks teroyks marked this pull request as ready for review October 2, 2023 10:36
@teroyks teroyks requested a review from akx October 2, 2023 10:36
@teroyks
Copy link
Contributor Author

teroyks commented Oct 2, 2023

Before merging to master, will check with everyone to make sure nobody is working on a large change that this would totally break.

Copy link
Member

@akx akx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Needs to be merged with a regular merge commit so the blame-ignore commit ID works!

@teroyks teroyks merged commit fd1ff73 into master Oct 2, 2023
6 checks passed
@teroyks teroyks deleted the tero/taco/format-with-black branch October 2, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reformat Code to Current Standard
4 participants