Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More lenient Override parsing #118

Merged
merged 3 commits into from
Sep 22, 2023
Merged

More lenient Override parsing #118

merged 3 commits into from
Sep 22, 2023

Conversation

akx
Copy link
Member

@akx akx commented Sep 22, 2023

Refs customer issue trying to look at a legacy config that's unparseable by newer valohai-yamls.

@akx akx requested review from a user, hylje and memona008 and removed request for a team September 22, 2023 06:27
Copy link
Contributor

@hylje hylje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, reasonable changes & test case

@codecov-commenter
Copy link

Codecov Report

Merging #118 (5b03c6e) into master (f4aab53) will increase coverage by 0.01%.
The diff coverage is 91.89%.

@@            Coverage Diff             @@
##           master     #118      +/-   ##
==========================================
+ Coverage   92.50%   92.51%   +0.01%     
==========================================
  Files          61       61              
  Lines        1894     1910      +16     
  Branches      320      324       +4     
==========================================
+ Hits         1752     1767      +15     
  Misses         71       71              
- Partials       71       72       +1     
Files Changed Coverage Δ
valohai_yaml/lint.py 92.10% <88.23%> (+0.10%) ⬆️
valohai_yaml/objs/pipelines/override.py 98.14% <90.00%> (-1.86%) ⬇️
tests/test_pipeline.py 93.61% <100.00%> (+1.11%) ⬆️
valohai_yaml/objs/pipelines/execution_node.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@akx akx merged commit 36119ba into master Sep 22, 2023
7 checks passed
@akx akx deleted the lenient-override branch September 22, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants